[vcpkg-tool-meson] Fix installation #35957
Conversation
| COMMAND "${CMAKE_COMMAND}" | ||
| "-DSOURCE_PATH=${SOURCE_PATH}" | ||
| "-DCURRENT_PACKAGES_DIR=${CURRENT_PACKAGES_DIR}" | ||
| -P "${CURRENT_PORT_DIR}/install.cmake" |
There was a problem hiding this comment.
Why use a install script here?
There was a problem hiding this comment.
It allows to easily redirect the output.
There was a problem hiding this comment.
Use COPY instead of INSTALL in the script then?
I dont think there is a reason to keep an install log here
There was a problem hiding this comment.
I wish the original change would have received this attention.
| ) | ||
|
|
||
| configure_file("${CMAKE_CURRENT_LIST_DIR}/vcpkg-port-config.cmake" "${CURRENT_PACKAGES_DIR}/share/${PORT}/vcpkg-port-config.cmake" @ONLY) |
There was a problem hiding this comment.
there is no reason to change this
There was a problem hiding this comment.
There is no reason to use configure_file.
There was a problem hiding this comment.
the PR updating meson will just change it back since meson will be moved back into DOWNLOADS an downloaded in the port config. As such this adds just another blame entry.
And since it is moved into downloads it will get directly extracted there.
Cheney-W
added
the
category:port-feature
|
I don't think there's value in creating a log for file copies like this, but I also don't really see harm either. I'm going to merge as is given that we have a clean build.
The problem this PR fixes is a problem created by not consuming meson from |
|
Thanks! |
[vcpkg-tool-meson] Fix installation (microsoft#35957)
Fixes #35795.
Fixes binary caching.