[mesa] Features, dependencies and CI

[dg0yt]

Revises dependencies and configuration.
Add feature for controlling vulkan support.
Enable CI.

[Neumann-A]

Suggested change

	"description": "Build with LLVM",
	"description": "Build llvmpipe",

?

[dg0yt]

This feature doesn't only control llvmpipe but also some other drivers.

[Neumann-A]

doesn't most (all) of them just depend on llvmpipe and not llvm itself?

[dg0yt]

If the feature would be called "llvmpipe", I probably wouldn't have touched it like this.

just depend on llvmpipe and not llvm itself

At least mesa also wants llvm[target-amdgpu] for with_gallium_radeonsi.
So either llvm becomes a mandatory dependency (rendering feature llvm nearly pointless), or the feature really controls the llvm dependency (this PR).

[JavierMatosD]

I'm putting this PR on hold for now. We need to update our VMs to include libxcb-dri3-dev in our Linux CI environment, as the changes to scripts/azure-pipelines/linux/managed-image.json don't actually change anything. Tagging this as depends:vm-update. Once our VMs are updated, someone can pick this up and have all the context they need. Here's a quick rundown of what's in the PR:

1. Shared GLAPI Condition: Now builds shared GLAPI if either OpenGL API or EGL is enabled. Previously, it was limited to OpenGL API.
2. Valgrind Dependency: Removed the dependency on Valgrind.
3. VM Configuration: Switched -Dshared-llvm from auto to disabled. The auto-detection was failing because LLVM is ONLY_STATIC_LIBRARY.
4. gslangValidator: Added to ADDITIONAL_BINARIES if glslang is available.
5. CI Environment: Updated to add libxcb-dri3-dev, but this depends on our VM update.
6. In vcpkg.json: Simplified the default features list, introduced optional Vulkan support, and expanded LLVM support, including for AMD GPUs.

I'll revisit this PR once our VMs are all set. Until then, it's on hold but ready for action post-update. 🚀

@dg0yt, feel free to jump in if I've missed something or if there's anything that needs correction.

[Cheney-W]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[dg0yt]

@BillyONeal et al. Artifact uploads seems to broken, error: curl failed to put file to ... everywhere, https://dev.azure.com/vcpkg/public/_build/results?buildId=99766&view=logs&j=7922e5c4-0103-5f8f-ad17-45ce9bb98e80.

[yurybura]

@dg0yt Are there plans to complete these changes? I'm interested in updating Mesa to the latest build to support LLVM 18. See #37599.

[dg0yt]

Are there plans to complete these changes? I'm interested in updating Mesa to the latest build to support LLVM 18. See #37599.

@yurybura Yes. The delay is from getting additional system packages applied to the CI images, to enable CI for linux and osx. This happens once in a month... I would do a mesa update once CI works for these platforms.
That being said, I consider llvm significant enough to accept parallel mesa update work. It should perhaps be limited to minimal changes within the current CI coverage.

[dg0yt]

Any other meson port invoking CMake's check_c_source_compiles?
mesonbuild/meson#13049

[yurybura]

@dg0yt Is there any progress in this PR?

[dg0yt]

Not so soon.
On x64-linux, there is now an LLVM issue:

/usr/bin/ld: /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libLLVMSupport.a(Process.cpp.o): in function `terminalHasColors(int)':
/mnt/vcpkg-ci/b/llvm/src/org-17.0.2-5fdca9a361.clean/llvm/lib/Support/Unix/Process.inc:354: undefined reference to `set_curterm'
/usr/bin/ld: /mnt/vcpkg-ci/b/llvm/src/org-17.0.2-5fdca9a361.clean/llvm/lib/Support/Unix/Process.inc:356: undefined reference to `setupterm'
/usr/bin/ld: /mnt/vcpkg-ci/b/llvm/src/org-17.0.2-5fdca9a361.clean/llvm/lib/Support/Unix/Process.inc:374: undefined reference to `tigetnum'
/usr/bin/ld: /mnt/vcpkg-ci/b/llvm/src/org-17.0.2-5fdca9a361.clean/llvm/lib/Support/Unix/Process.inc:380: undefined reference to `set_curterm'
/usr/bin/ld: /mnt/vcpkg-ci/b/llvm/src/org-17.0.2-5fdca9a361.clean/llvm/lib/Support/Unix/Process.inc:381: undefined reference to `del_curterm'

I think I have been there before, some kind of installation order issue. But I can't rebuild LLVM so many time as I would need to.

[yurybura]

I'm trying to support at least mesa:x64-windows. The meson tool needs to be updated and patched to support LLVM 18.1.x (see mesonbuild/meson@dec93ce).

[dg0yt]

As I said, go ahead with llvm as you like. Just keep changes to mesa minimal.

[dg0yt]

Not so soon. On x64-linux, there is now an LLVM issue:

/usr/bin/ld: /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libLLVMSupport.a(Process.cpp.o): in function `terminalHasColors(int)':
/mnt/vcpkg-ci/b/llvm/src/org-17.0.2-5fdca9a361.clean/llvm/lib/Support/Unix/Process.inc:354: undefined reference to `set_curterm'
/usr/bin/ld: /mnt/vcpkg-ci/b/llvm/src/org-17.0.2-5fdca9a361.clean/llvm/lib/Support/Unix/Process.inc:356: undefined reference to `setupterm'
/usr/bin/ld: /mnt/vcpkg-ci/b/llvm/src/org-17.0.2-5fdca9a361.clean/llvm/lib/Support/Unix/Process.inc:374: undefined reference to `tigetnum'
/usr/bin/ld: /mnt/vcpkg-ci/b/llvm/src/org-17.0.2-5fdca9a361.clean/llvm/lib/Support/Unix/Process.inc:380: undefined reference to `set_curterm'
/usr/bin/ld: /mnt/vcpkg-ci/b/llvm/src/org-17.0.2-5fdca9a361.clean/llvm/lib/Support/Unix/Process.inc:381: undefined reference to `del_curterm'

I think I have been there before, some kind of installation order issue. But I can't rebuild LLVM so many time as I would need to.

Welcome to meson's incomplete ability to import transitive dependencies from CMake, paired with vcpkg's incomplete ability to provide a consistent foo-config script experience.