Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libdrm] New port #39242

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[libdrm] New port #39242

wants to merge 1 commit into from

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Jun 12, 2024

To be used (at least) by mesa.

@dg0yt dg0yt marked this pull request as ready for review June 12, 2024 06:02
@JonLiu1993 JonLiu1993 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Jun 12, 2024
@Neumann-A
Copy link
Contributor

deja vu, was also part of #26858. Requires libpciaccess.
Question was: Should this be provided by the system (were exactly does vcpkg want to put the boundary)?

@dg0yt
Copy link
Contributor Author

dg0yt commented Jun 12, 2024

Requires libpciaccess.

Or simply auto-disables libdrm_intel.

Question was: Should this be provided by the system (were exactly does vcpkg want to put the boundary)?

👍
With the added difficulty of desktop systems generally using shared libs, vcpkg CI building static libs.

@dg0yt
Copy link
Contributor Author

dg0yt commented Jun 12, 2024

This PR is also integrated in #36081 to provide a more recent libdrm to mesa.

@Neumann-A
Copy link
Contributor

With the added difficulty of desktop systems generally using shared libs, vcpkg CI building static libs.

#27279 removed all system libs so it is theoretically possible. The question is: Is it practical?
If vcpkg wants to make those libs shared it could simply use per port customization in the triplet.
I am a bit torn if those libs should be system provided or not. It seems like all those libs are user space any way and could be provided by vcpkg.

@dg0yt
Copy link
Contributor Author

dg0yt commented Jun 12, 2024

The task is to have reasonable CI coverage for ports like mesa.
I wouldn't mind having a few more system dependencies made explicit via empty ports, and to add overlay ports to fill gaps in CI.

Things get tricky when system packages pull in runtime libs which are also libs in vcpkg. libdrm is a candidate...

@dg0yt
Copy link
Contributor Author

dg0yt commented Jun 12, 2024

Using libs provided by the operating system might also mitigate some licensing concerns.

@BillyONeal BillyONeal added the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label Jun 12, 2024
@BillyONeal
Copy link
Member

Tagging vcpkg-team-review: I'm really nervous about checking in a copy of the license which is not anchored in any way to where the code comes from, thus making bugs where we claim the license is one thing and it's actually something else in the future.

@dg0yt
Copy link
Contributor Author

dg0yt commented Jun 13, 2024

I'd be really nervous about the superficial copyright files for most ports. While vcpkg started with ideas from Debian packaging (CONTROL, copyright), it didn't really adopt the thorough copyright part, and the gap is significant and obvious.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants