[pulsar-client-cpp] Fix build failure when CMAKE_BUILD_TYPE is not specified

[BewareMyPower]

• Changes comply with the maintainer guide
• SHA512s are updated for each updated download
• The "supports" clause reflects platforms that may be fixed by this new version
• Any fixed CI baseline entries are removed from that file.
• Any patches that are no longer applied are deleted from the port's directory.
• The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
• Only one version is added to each modified port's versions file.

This patch mainly fixes the error that when CMAKE_BUILD_TYPE is not specified with a single-configuration generator, the build will fail because the imported location cannot be found.

For example, in <cmake-build-dir>/CMakeFiles/<target.dir>/build.cmake, there could be a line like:

<target>: unofficial::pulsar::pulsar-NOTFOUND

This patch fixes the error above by making unofficial::pulsar::pulsar links debug libraries by default.

In addition, fix the error that Snappy cannot be found on Linux and the logic to find libraries of the pulsar library.

[BewareMyPower]

I verified the patch with the following triplets in GitHub actions, see BewareMyPower#2.

• x64-windows
• x64-windows-static
• x64-linux
• x64-linux-dynamic
• x64-osx
• x64-osx-dynamic

And the arm64-osx triplet is verified locally on my m1 laptop.

[BewareMyPower]

For Unix Makefiles, when I ran cmake -B build and then ran cd build && make VERBOSE=1, I found the following static libraries were linked:

• vcpkg_installed/arm64-osx/lib/libpulsar.a
• vcpkg_installed/arm64-osx/debug/lib/libprotobufd.a
• vcpkg_installed/arm64-osx/debug/lib/libcurl-d.a
• vcpkg_installed/arm64-osx/debug/lib/libssl.a
• vcpkg_installed/arm64-osx/debug/lib/libcrypto.a
• vcpkg_installed/arm64-osx/lib/libz.a
• vcpkg_installed/arm64-osx/debug/lib/libzstd.a
• vcpkg_installed/arm64-osx/debug/lib/libsnappy.a

So I think the debug version of libpulsar.a should be linked with the default config. What confused me is that lib/libz.a but not debug/lib/libz.a is linked .

[BewareMyPower]

Just found FindZLIB.cmake sets ZLIB_LIBRARY via select_library_configurations, which chooses the release library by default.

    if( ${basename}_LIBRARY_DEBUG AND ${basename}_LIBRARY_RELEASE AND
           NOT ${basename}_LIBRARY_DEBUG STREQUAL ${basename}_LIBRARY_RELEASE AND
           ( _isMultiConfig OR CMAKE_BUILD_TYPE ) )
        # ...
    elseif( ${basename}_LIBRARY_RELEASE )
        set( ${basename}_LIBRARY ${${basename}_LIBRARY_RELEASE} )
    elseif( ${basename}_LIBRARY_DEBUG )
        set( ${basename}_LIBRARY ${${basename}_LIBRARY_DEBUG} )
    else()
        set( ${basename}_LIBRARY "${basename}_LIBRARY-NOTFOUND")
    endif()

Also, after learning FindZLIB.cmake, it seems that target pattern contains no '%' was not caused by the IMPORTED_LOCATION not set. I will recheck the issue.

[BewareMyPower]

@Neumann-A I updated the PR description and the cmake code, PTAL again. Now with Makefile as the generator, all debug libraries will be linked when CMAKE_BUILD_TYPE is not specified. See the verbose output on my local env:

/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ -g -arch arm64 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.3.sdk -Wl,-search_paths_first -Wl,-headerpad_max_install_names CMakeFiles/HelloWorld.dir/helloworld.cpp.o -o HelloWorld vcpkg_installed/arm64-osx/debug/lib/libpulsar.a vcpkg_installed/arm64-osx/debug/lib/libprotobufd.a vcpkg_installed/arm64-osx/debug/lib/libcurl-d.a vcpkg_installed/arm64-osx/debug/lib/libssl.a vcpkg_installed/arm64-osx/debug/lib/libcrypto.a vcpkg_installed/arm64-osx/debug/lib/libz.a -framework SystemConfiguration -framework CoreFoundation -framework CoreServices vcpkg_installed/arm64-osx/debug/lib/libzstd.a vcpkg_installed/arm64-osx/debug/lib/libsnappy.a

[JonLiu1993]

Tested usage successfully by pulsar-client-cpp:x64-windows:

pulsar-client-cpp provides CMake targets:

  find_package(unofficial-pulsar CONFIG REQUIRED)
  target_link_libraries(main PRIVATE unofficial::pulsar::pulsar)