[ffmpeg] OpenSSL feature requires LGPL v3, not non-free license #36879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrankXie05
added
the
category:port-feature
FrankXie05
previously approved these changes
Feb 22, 2024
vicroms
added
requires:vcpkg-team-review
|
This seems fine to me once the merge conflicts have been fixed. |
OpenSSL has moved to Apache 2 license, which is clearly compatible with LGPL v3 (but not v2.1, which is ffmpeg's default). Note that FFmpeg devs believe that the previous license is also compatible with LGPL (any version), but not GPL. See https://github.com/FFmpeg/FFmpeg/blob/37702e20663dc8111534229af551763c2a954e73/LICENSE.md#incompatible-libraries for more details. Note that the upstream also believes that Fraunhofer FDK AAC is also compatible with LGPL, but IANAL and fdk-aac uses its own custom license.
horenmar
force-pushed
the
update-ffmpeg-licensing
branch
from
70e1eb7
to
c731f91
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenSSL has moved to Apache 2 license, which is clearly compatible with LGPL v3 (but not v2.1, which is ffmpeg's default). Note that FFmpeg devs believe that the previous license is also compatible with LGPL (any version), but not GPL.
See https://github.com/FFmpeg/FFmpeg/blob/37702e20663dc8111534229af551763c2a954e73/LICENSE.md#incompatible-libraries for more details.
Note that the upstream also believes that Fraunhofer FDK AAC is also compatible with LGPL, but IANAL and fdk-aac uses its own custom license.
SHA512s are updated for each updated download.The "supports" clause reflects platforms that may be fixed by this new version.Any fixed CI baseline entries are removed from that file.Any patches that are no longer applied are deleted from the port's directory../vcpkg x-add-version --alland committing the result.