[directxmath] port update to fix include path in pkgconfig #37151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Upstream fix can be seen here: microsoft/DirectXMath#188 |
WangWeiLin-MV
added
the
category:port-update
WangWeiLin-MV
requested changes
Mar 6, 2024
|
The version date matches the NuGet package and GitHub releases that have the idential header files. The only differenence between feb2024 and feb2024b is the one CMakeLists.txt fix to pkgconfig. There is no functional difference at all, which is why I went with a port-version update instead. It's basically a VCPKG only hot-fix. |
WangWeiLin-MV
approved these changes
Mar 7, 2024
WangWeiLin-MV
added
the
info:reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The include path in the generated pkgconfig was incorrect. This updates the port to use the version upstream with this fix.