Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg-qmake] Remove unnecessary directory #37752

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

JonLiu1993
Copy link
Member

@JonLiu1993 JonLiu1993 commented Mar 27, 2024

Recently when I was using vcpkg-qmake, I found that a function in the ports/vcpkg-qmake/vcpkg_qmake_configure.cmake file was repeated:

configure_file("${VCPKG_QT_CONF_${buildtype}}" "${CURRENT_BUILDTREES_DIR}/${config_triplet}/qt.conf")

By running this line of code, we will configure the generated qt.conf file. At the same time, if the ${CURRENT_BUILDTREES_DIR}/${config_triplet}/ path does not exist, we will also generate it.
Then we back up the environment variables and run the code
file(MAKE_DIRECTORY "${CURRENT_BUILDTREES_DIR}/${config_triplet}")
to generate the existing path above.

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@JonLiu1993 JonLiu1993 added info:internal This PR or Issue was filed by the vcpkg team. category:code-cleanup This PR cleans up code, without fixing any existing bugs nor adding any features. labels Mar 27, 2024
@JonLiu1993 JonLiu1993 marked this pull request as ready for review March 27, 2024 09:23
@BillyONeal BillyONeal changed the title [vcpkg-qmake] Remove unnecessary functions [vcpkg-qmake] Remove unnecessary directory Mar 27, 2024
@jimwang118 jimwang118 added the info:reviewed Pull Request changes follow basic guidelines label Mar 28, 2024
@BillyONeal BillyONeal merged commit c4c8038 into microsoft:master Mar 28, 2024
16 checks passed
@BillyONeal
Copy link
Member

Thanks :)

@JonLiu1993 JonLiu1993 deleted the dev/Jon/vcpkg_qmake_configure branch March 29, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:code-cleanup This PR cleans up code, without fixing any existing bugs nor adding any features. info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants