-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[opencv] update to 4.9 #38928
base: master
Are you sure you want to change the base?
[opencv] update to 4.9 #38928
Conversation
-DWITH_DSHOW=${WITH_DSHOW} | ||
-DBUILD_opencv_calib3d=${BUILD_opencv_calib3d} | ||
-DBUILD_opencv_highgui=${BUILD_opencv_highgui} | ||
${ADDITIONAL_BUILD_FLAGS} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also fix python installation behavior.
I needed to add:
-D__INSTALL_PATH_PYTHON3=${CURRENT_PACKAGES_DIR}/${PYTHON3_SITE}/cv2
and for cleanup later:
file(GLOB python_dir LIST_DIRECTORIES true RELATIVE "${CURRENT_PACKAGES_DIR}/lib/" "${CURRENT_PACKAGES_DIR}/lib/python*")
file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/lib/${python_dir}/site-packages/cv2/typing")
file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/debug/lib/${python_dir}/site-packages/cv2/typing")
However if the install logs show that python bindings get installed into the right directory already than consider this obsolete.
…nto dev/cenit/opencv49
Co-authored-by: Javier Matos <javiermatos@Javiers-Laptop.local>
Co-authored-by: Kai Pastor <dg0yt@darc.de>
…pe (microsoft#39798) Co-authored-by: 王方凯 <fk.wang@hydro-tech.cn>
the residual error on openvino due to pkgconf missing is triggered by a bug in cmake. This is in fact the snippet in FindOpenSSL.cmake official module:
as you can see, the module is using |
AFAICT |
Fixes #39884
Fixes #39835
Fixes #39651
Fixes #39454
Fixes #39224
Fixes #38321
Fixes #36771
Fixes #36093
Fixes #36009
Fixes #35937
Fixes #34559
Fixes #34279
Fixes #33742
Fixes #32228
Fixes #17850
Fixes #13120
Fixes #4937
Depending on #39703 (need to remove ffmpeg from ci.baseline here after that PR acceptance)./vcpkg x-add-version --all
and committing the result.