Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libtracepoint] Update to 1.4.0, add "tools" features #39418

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

idigdoug
Copy link
Contributor

@idigdoug idigdoug commented Jun 21, 2024

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Comment on lines 16 to 17
OPTIONS ${FEATURE_OPTIONS}
-DBUILD_SAMPLES=OFF)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
OPTIONS ${FEATURE_OPTIONS}
-DBUILD_SAMPLES=OFF)
OPTIONS
${FEATURE_OPTIONS}
-DBUILD_SAMPLES=OFF
)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions like these are really annoying -- they're just minor formatting opinion, but accepting them causes the versions database to get out of sync and requires recreating the PR and rebuilding the versions database, which is not worthwhile for a minor formatting suggestion.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to "recreate the PR". And once CI passed (except for versioning) after committing the suggestions, one more commit to update the versioning can reuse cached CI artifacts even for the port of interest.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's basically what I mean -- I had to recreate the versions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@idigdoug
Sorry for not explaining in detail, line wrapping consistent with other ports facilitates subsequent updates and clear git diff searching.

And for version database sync of multiple ports, here is a command option vcpkg x-add-version --all --overwrite-version could help.

ports/libeventheader-decode/portfile.cmake Outdated Show resolved Hide resolved
ports/libeventheader-tracepoint/portfile.cmake Outdated Show resolved Hide resolved
ports/libtracepoint-control/portfile.cmake Outdated Show resolved Hide resolved
ports/libtracepoint-control/portfile.cmake Outdated Show resolved Hide resolved
ports/libtracepoint/portfile.cmake Outdated Show resolved Hide resolved
@WangWeiLin-MV WangWeiLin-MV added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:port-update The issue is with a library, which is requesting update new revision labels Jun 21, 2024
Copy link
Contributor

@WangWeiLin-MV WangWeiLin-MV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ports and features installation tests pass with the following triplets:

  • x64-linux

@WangWeiLin-MV WangWeiLin-MV added the info:reviewed Pull Request changes follow basic guidelines label Jun 24, 2024
@BillyONeal BillyONeal merged commit 54fb22e into microsoft:master Jun 25, 2024
17 checks passed
@BillyONeal
Copy link
Member

Thanks for the update and feature!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants