-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libtracepoint] Update to 1.4.0, add "tools" features #39418
Conversation
OPTIONS ${FEATURE_OPTIONS} | ||
-DBUILD_SAMPLES=OFF) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OPTIONS ${FEATURE_OPTIONS} | |
-DBUILD_SAMPLES=OFF) | |
OPTIONS | |
${FEATURE_OPTIONS} | |
-DBUILD_SAMPLES=OFF | |
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestions like these are really annoying -- they're just minor formatting opinion, but accepting them causes the versions database to get out of sync and requires recreating the PR and rebuilding the versions database, which is not worthwhile for a minor formatting suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no need to "recreate the PR". And once CI passed (except for versioning) after committing the suggestions, one more commit to update the versioning can reuse cached CI artifacts even for the port of interest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's basically what I mean -- I had to recreate the versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@idigdoug
Sorry for not explaining in detail, line wrapping consistent with other ports facilitates subsequent updates and clear git diff searching.
And for version database sync of multiple ports, here is a command option vcpkg x-add-version --all --overwrite-version could help.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ports and features installation tests pass with the following triplets:
- x64-linux
Thanks for the update and feature! |
./vcpkg x-add-version --all
and committing the result.