[vcpkg baseline][c-ares] Add unsupported uwp platform #40213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimwang118
added
category:port-bug
WangWeiLin-MV
approved these changes
Aug 1, 2024
|
@jimwang118 you should also change curl ci test, and move c-ares, to be platform: "!uwp" |
|
I merged this to unblock #40203 . Thanks for the fix! |
|
I notified upstream: c-ares/c-ares#785 (comment) |
bradh352
added a commit
to c-ares/c-ares
that referenced
this pull request
Aug 1, 2024
Because AppVeyor's version of MSVC needed to be patched to build UWP applications: https://developercommunity.visualstudio.com/t/clexe-compiler-error-C1007-when-compili/10486219 We ended up disabling UWP builds in our CI environment. It turns out UWP support had broken in the meantime: microsoft/vcpkg#40213 This PR fixes the build regression and also adds a GitHub action CI workflow for building the UWP app so we can catch this in the future. Fix By: Brad House (@bradh352)
|
Fixed in c-ares/c-ares@3fd5925 |
bradh352
added a commit
to c-ares/c-ares
that referenced
this pull request
Aug 2, 2024
Because AppVeyor's version of MSVC needed to be patched to build UWP applications: https://developercommunity.visualstudio.com/t/clexe-compiler-error-C1007-when-compili/10486219 We ended up disabling UWP builds in our CI environment. It turns out UWP support had broken in the meantime: microsoft/vcpkg#40213 This PR fixes the build regression and also adds a GitHub action CI workflow for building the UWP app so we can catch this in the future. Fix By: Brad House (@bradh352)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failed on: https://dev.azure.com/vcpkg/public/_build/results?buildId=105429&view=results
The UnregisterWait and NotifyIpInterfaceChange functions are Win32 system functions and are not defined under UWP. Therefore, adding them does not support the UWP platform.
SHA512s are updated for each updated download.The "supports" clause reflects platforms that may be fixed by this new version.Any fixed CI baseline entries are removed from that file.Any patches that are no longer applied are deleted from the port's directory../vcpkg x-add-version --alland committing the result.Usage test pass with following triplets: