Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libdatachannel] Update, cleanup #40337

Merged
merged 1 commit into from
Aug 9, 2024
Merged

[libdatachannel] Update, cleanup #40337

merged 1 commit into from
Aug 9, 2024

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Aug 7, 2024

Complements #40335

@dg0yt dg0yt mentioned this pull request Aug 7, 2024
Closed
@dg0yt dg0yt marked this pull request as ready for review August 7, 2024 16:08
@JonLiu1993 JonLiu1993 self-assigned this Aug 8, 2024
@JonLiu1993 JonLiu1993 added category:port-update The issue is with a library, which is requesting update new revision category:code-cleanup This PR cleans up code, without fixing any existing bugs nor adding any features. labels Aug 8, 2024
@JonLiu1993
Copy link
Member

All features are tested successfully in the following triplet:

  • x86-windows
  • x64-windows
  • x64-windows-static

@JonLiu1993
Copy link
Member

Tested usage successfully by libdatachannel[*]:x64-windows:

libdatachannel provides CMake targets:

  # this is heuristically generated, and may not be correct
  find_package(LibDataChannel CONFIG REQUIRED)
  target_link_libraries(main PRIVATE LibDataChannel::LibDataChannelStatic)

@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Aug 8, 2024
@data-queue data-queue merged commit 8ae59b5 into microsoft:master Aug 9, 2024
16 checks passed
@dg0yt dg0yt deleted the libdatachannel branch August 9, 2024 04:54
@tdarbinyan tdarbinyan mentioned this pull request Aug 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonLiu1993 JonLiu1993 JonLiu1993 approved these changes

@data-queue data-queue data-queue approved these changes

Assignees

@JonLiu1993 JonLiu1993

Labels
category:code-cleanup This PR cleans up code, without fixing any existing bugs nor adding any features. category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dg0yt @JonLiu1993 @data-queue