[sqlpp11,vcpkg-ci-sqlpp11] Fixes, cleanup, test port #41128
Merged
+135
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrankXie05
added
the
category:infrastructure
dg0yt
changed the title
FrankXie05
approved these changes
Sep 24, 2024
BillyONeal
reviewed
Sep 24, 2024
Comment on lines
576
to
577
| libmariadb:arm-neon-android=fail | ||
| libmariadb:arm64-android=fail |
There was a problem hiding this comment.
Given that libmysql has "supports": "!android & !mingw & !uwp & !xbox", should libmariadb get the same supports clause and these two =fail lines be removed?
There was a problem hiding this comment.
Out of scope, and really two different packages at some point.
- Touching port libmariadb or port libmysql isn't part of this PR at the moment. However, the PR already touches
ci.baseline.txt. - I only need to change one broken CMake line to fix the build of libmariadb on android. It might also build for mingw.
- libmysql has a different set of dependencies (in particular: boost), and a different error (not finding libresolv for android).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41068.