OpenVDB: Add /bigobj as compiler flag only for MSVC
#4948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does it continue to build on MSVC? If it doesn't, you should make the removal conditional on the compiler; see #3442 for an example. |
|
I see. I wasn't aware of /bigobj being used on MSVC. I currently don't have a Windows machine but will use the fix you proposed 🙂 |
aaronang
force-pushed
the
fix-openvdb-patch
branch
from
b08b29c
to
15395a5
Compare
|
@sanxiyn Thank you for the feedback! I incorporated your feedback. |
aaronang
changed the title
/bigobj from patch file/bigobj as compiler flag only for MSVC
|
|
|
Thanks for the PR and happy holidays! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch should fix #4940.