Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libqglviewer] add new port #5024

Merged
merged 5 commits into from
Mar 7, 2019
Merged

Conversation

TheScarfix
Copy link
Contributor

Adding a new portfile for the QGLViewer library http://libqglviewer.com/

@Rastaban Rastaban self-assigned this Jan 16, 2019
@Rastaban
Copy link
Contributor

@TheScarfix I see failures in the static windows builds, are these expected?

@TheScarfix
Copy link
Contributor Author

http://libqglviewer.com/installWindows.html I think it is dll only
on windows, also haven't tested the other platforms yet

@Rastaban
Copy link
Contributor

Rastaban commented Mar 6, 2019

Our CI system avoids building ports that are unchanged by caching the installed files. qt5-base is doing something that causes it to not be cached correctly in our system which can cause failures in dependent ports that should build correctly. I am looking into addressing that issue but it should not hold up this PR. To work around the issue I made a whitespace change in qt5-base which should get the system to do a clean build. I should be able to merge this change after that completes.

@TheScarfix
Copy link
Contributor Author

@Rastaban thank you :) will work on a linux compatible version as soon as I get the qmake system working there.

@Rastaban
Copy link
Contributor

Rastaban commented Mar 7, 2019

NP, thanks for the work! The tests looks better with the qt5-base rebuild so I am going to accept this port as is, when you get the Linux compatible version it can be added in a separate PR.

@Rastaban Rastaban merged commit 59744f4 into microsoft:master Mar 7, 2019
@myd7349 myd7349 mentioned this pull request Mar 7, 2019
5 tasks
@TheScarfix TheScarfix deleted the libqglviewer-2.7.1 branch April 28, 2019 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants