Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cairo] Update version to 1.17.2 #5646

Merged
merged 6 commits into from
Mar 15, 2019

Conversation

NancyLi1013
Copy link
Contributor

@NancyLi1013 NancyLi1013 added the info:internal This PR or Issue was filed by the vcpkg team. label Mar 12, 2019
@donny-dont
Copy link
Contributor

I would suggest waiting for another development release due to https://gitlab.freedesktop.org/cairo/cairo/issues/358 or add that patch

@Rastaban
Copy link
Contributor

Do you know when their next release is planned?

@donny-dont
Copy link
Contributor

No idea. I just mentioned it because we use vcpkg for the WebKit WinCairo port. We hit that issue when we updated.

WebKitForWindows/WebKitRequirements@5610dcb

@Rastaban
Copy link
Contributor

@NancyLi1013 could you add a patch for that issue? It looks like a small change. Also if there is an update to cairomm then we should probably update it at the same time because they are related.

@NancyLi1013
Copy link
Contributor Author

@Rastaban , I have added the patch above . Please help to check it. Thanks.

@Rastaban
Copy link
Contributor

@donny-dont could you verify that we are applying the patch that addresses the issue?

@donny-dont
Copy link
Contributor

@Rastaban the patch I added to mine was the fix at the time. They rolled back the offending commit completely in the patch they landed to close that particular issue.

For our WebKit port the fix applied seemed to remove our crashes. Cairo folks still need to sort it all out but I'd potentially recommend just applying their patch or just using 1.16.0

@Rastaban
Copy link
Contributor

@NancyLi1013 Sorry to keep changing things on you. After looking at it more it seems like the Cairo folks are still trying to figure out how they want to resolve the issue. Rather than grabbing their patch in the middle of their fixes lets just avoid the issue for now by using the 1.16.0 release, that will still satisfy the original issue.

@Rastaban Rastaban self-assigned this Mar 14, 2019
@NancyLi1013
Copy link
Contributor Author

@Rastaban , it doesn't matter about this. Now I have updated the package to 1.16.0. Thanks a lot for your clear clarification.

@@ -0,0 +1,78 @@
From 61cd11a39095cb51b9e87beba10905e895567151 Mon Sep 17 00:00:00 2001
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this file can now be removed from the PR.

@Rastaban Rastaban merged commit 9ca11f3 into microsoft:master Mar 15, 2019
@zcream
Copy link

zcream commented Feb 3, 2021

@Rastaban @NancyLi1013 Cairo 1.17.2 is now stable. The changelog incorporates float format so its a major improvement. Could this be offered in the official vcpkg ? https://www.cairographics.org/news/cairo-1.17.2/
Pixman is also updated to 0.36.0

@NancyLi1013
Copy link
Contributor Author

Thanks for your kindly reminder @zcream.

I noticed that the latest version is 1.17.4. I will try to update it these days in vcpkg.

@donny-dont
Copy link
Contributor

Cairo 1.17.4 doesn't have the issue that 1.17.2 has. Pixman is also at 0.40.0. We're using both.

Wouldn't recommend using it in any new projects though since development isn't happening, see https://news.ycombinator.com/item?id=25076197

@NancyLi1013
Copy link
Contributor Author

Thanks for your information @donny-dont.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants