[libffi] Update to v3.3 release #6119
Conversation
|
Thanks for all of the new PRs! With this one I see a new build failure with libffi on osx and Linux. Are you able to investigate those? Also do you know when libffi is planning on releasing 3.3? We prefer to stick with official releases rather than switching to an unofficial repro and using a hash. |
|
@Rastaban I agree with you about the official releases, this is currently just a temporary hack for testing & using glib on arm-windows / arm64-windows. That is also why it is marked as WIP. |
|
I'll see what I can do to the Linux side of things soon. As for OS X, I don't have a Mac so sorry about that. (Maybe they are related though) |
|
Hey @driver1998, here is the failure log for |
|
|
|
With this commit I also updated to a more recent commit, and we are pretty close to main branch right now (waiting for one more PR to upstream). |
|
|
|
Hey @driver1998, could you please link the upstream pull requests so we can follow along with the progress? |
|
Let's move forward with this by pulling the PR branch, since upstream hasn't looked at the PR in a month. |
|
Now libffi/libffi#486 is merged, I am going to move to upstream master... |
|
libffi/libffi#490 contains one more patch over libffi/libffi#486 (and the current upstream), which is added as a patch to the port. The new PR for this patch is libffi/libffi#496. |
|
Now everything we need is in upstream master, only to wait for.an official 3.3 release... |
cbezault
added
the
depends:upstream-changes
`boost-python` depends on `python3`, which in turn depends on `libffi`, which is not available for arm (see microsoft#6119, pending upstream release 3.3). Until this becomes fixed, drop `boost-python` from packages `boost` depends on, so it can be built for arm. https://github.com/microsoft/vcpkg/blob/75b4620da5c201d577426aafe101ecb045e7411b/ports/boost-python/CONTROL#L4 https://github.com/microsoft/vcpkg/blob/75b4620da5c201d577426aafe101ecb045e7411b/ports/python3/CONTROL#L5
In the meantime, libffi 3.3 Release Candidate 1 has been released (2019-10-24). However, not the official 3.3 yet, but definitely worth testing. |
|
Adding the more recent version which supports arm64 would be great. Last night I hacked together a portfile to build the arm64 lib using the msbuild function. I would prefer the port be updated rather than my hack. |
driver1998
changed the title
|
Rebased this branch to current vcpkg master, and upgrade to libffi v3.3-rc2 (just released). |
|
Resolved. |
|
@driver1998, thanks for updates! The CI failed with following failures, could you please take a look? if this is expected, could you please update them to ci.baseline.txt file? ##[error] REGRESSION: libnice:arm64-windows |
atk compilation requires running glib(arm64) tools, which is not possible on a x86 system.
|
Should be resolved now. |
PhoebeHui
added
info:reviewed
…riables instead. Avoid double expansion inside if().
|
Thanks for the PR! |
* libffi 3.3-rc0 custom port, with arm/arm64 windows support * fix linux build * enable EFI64 in linux x64, should fix build errors in some cases * libffi: move to the arm64 support pr branch * libffi: move to latest upstream master * libffi: update to upstream master * libffi: update to v3.3-rc2 * libffi: update to v3.3 release * libffi: update version in fficonfig.h * libffi: Remove CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS * [libffi] update portfile.cmake * [libnice] fix Windows ARM64 build * CI: set atk:arm64-windows to fail atk compilation requires running glib(arm64) tools, which is not possible on a x86 system. * CI: libffi:arm64-windows passing * [gdk-pixbuf] fix Windows ARM64 build * [pangomm] show unsupported architecture error on ARM * [pangomm] update portfile.cmake * [libffi] Avoid depending on VCPKG_TARGET_TRIPLET; use native cmake variables instead. Avoid double expansion inside if(). * [libffi] TARGET is a keyword for if() -- use quoted expansion instead. Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
Update: v3.3 finally released(3e249f826e77c57f4a85be746dcfd1f891ab90f4), hopefully it will just work.
This is a port of libffi master as of Apr 10 (d1e9b4b), with both libffi/libffi#483 (arm64 support) and libffi/libffi#477 (arm32 support).This port is work in progress.