[glib] arm/arm64 windows support #6116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for enabling this, @driver1998! |
gnomesysadmins
pushed a commit
to GNOME/glib
that referenced
this pull request
Sep 18, 2020
Symbols on x86 are prefixed with an underscore but symbols on x64/ARM/ARM64 are not. Relevant information concerning the prefixes for the architectures can be found in the vcpkg project [1,2], where arm and arm64 builds are part of the CI. Specifically, _WIN64 is defined on Windows ARM64, so this issue is only visible when building on ARM32. [1] https://github.com/microsoft/vcpkg/blob/08e74979df124d9360343751cefcae615c2ec5ed/ports/glib/fix-arm-builds.patch [2] microsoft/vcpkg#6116
gnomesysadmins
pushed a commit
to GNOME/glib
that referenced
this pull request
Sep 23, 2020
Symbols on x86 are prefixed with an underscore but symbols on x64/ARM/ARM64 are not. Relevant information concerning the prefixes for the architectures can be found in the vcpkg project [1,2], where arm and arm64 builds are part of the CI. Specifically, _WIN64 is defined on Windows ARM64, so this issue is only visible when building on ARM32. [1] https://github.com/microsoft/vcpkg/blob/08e74979df124d9360343751cefcae615c2ec5ed/ports/glib/fix-arm-builds.patch [2] microsoft/vcpkg#6116
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For it to actually build on Windows ARM/ARM64, a proper libffi port is required.
I tested with combination of libffi/libffi#483 and libffi/libffi#477, which works fine.
A WIP port of said libffi build is at #6119.
It should work once both of these PRs are in.