Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pthread] update to v3 #6473

Merged
merged 4 commits into from
May 16, 2019
Merged

[pthread] update to v3 #6473

merged 4 commits into from
May 16, 2019

Conversation

cenit
Copy link
Contributor

@cenit cenit commented May 16, 2019

the upgrade is substantial, almost anything is left from previous port (v2, 5 years old). Might have broken everything...

@NancyLi1013
Copy link
Contributor

NancyLi1013 commented May 16, 2019

Hi @cenit, here are some regressions from the current CI system:

x64-windows master test notes
darknet Pass Fail Regression
arb Pass Fail Regression
usbmuxd Pass Fail Regression
x64-windows-static master test notes
pthreads Pass Fail Regression
x86-windows master test notes
darknet Pass Fail Regression
arb Pass Fail Regression
usbmuxd Pass Fail Regression

failureLogs.zip

I see you also update the files in flint and mosquitto. Could you also bump the CONTROL versions in these two ports?

@cenit
Copy link
Contributor Author

cenit commented May 16, 2019

@NancyLi1013 thanks for the quick reply. May I ask you updated informations after the last commit? Because I realized that the commit was not properly formatted, so i force-pushed it again.
I will bump CONTROL of touched ports at the end of the PR debug

@cenit
Copy link
Contributor Author

cenit commented May 16, 2019

ok all those regressions should be fixed

@cbezault cbezault merged commit ec46f02 into microsoft:master May 16, 2019
@cenit cenit deleted the dev/cenit/pthread branch May 16, 2019 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants