Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libraqm] Add new port (0.6.0) #6659

Merged
merged 9 commits into from
Jun 14, 2019
Merged

[libraqm] Add new port (0.6.0) #6659

merged 9 commits into from
Jun 14, 2019

Conversation

tobbi
Copy link
Contributor

@tobbi tobbi commented May 28, 2019

No description provided.

@tobbi tobbi changed the title [libraqm] New port [libraqm] Add new port (0.6.0) May 28, 2019
@NancyLi1013
Copy link
Contributor

Hi @tobbi, thanks for the new port. Here are the test results from the current CI system:

x64-windows test notes
libraqm Fail New Port
x64-windows-static test notes
libraqm Fail New Port
x64-osx test notes
libraqm Skip New Port
arm64-windows test notes
libraqm Skip New Port
x86-windows test notes
libraqm Fail New Port
x64-linux test notes
libraqm Skip New Port
x64-uwp test notes
libraqm Skip New Port
arm-uwp test notes
libraqm Skip New Port

failureLogs.zip

@tobbi
Copy link
Contributor Author

tobbi commented May 29, 2019

Curious. Building worked just fine on my machine, which is a Win 10 x64. Does anyone have any idea what could have gone wrong?

@Neumann-A
Copy link
Contributor

@tobbi: read the logs:

CMake Error at C:/vsts/_work/9/s/scripts/buildsystems/vcpkg.cmake:198 (_add_library):
  Target "raqm" links to target "unofficial::glib::glib" but the target was
  not found.  Perhaps a find_package() call is missing for an IMPORTED
  target, or an ALIAS target is missing?

you are simply missing a dependency

@tobbi
Copy link
Contributor Author

tobbi commented May 29, 2019

@tobbi: read the logs:

CMake Error at C:/vsts/_work/9/s/scripts/buildsystems/vcpkg.cmake:198 (_add_library):
  Target "raqm" links to target "unofficial::glib::glib" but the target was
  not found.  Perhaps a find_package() call is missing for an IMPORTED
  target, or an ALIAS target is missing?

you are simply missing a dependency

You see, when I built this locally, I didn't need that dependency. Here's a list of locally installed packages:

C:\vcpkg>vcpkg.exe list
bzip2:x64-windows                                  1.0.6-4          High-quality data compressor.
bzip2:x86-windows                                  1.0.6-4          High-quality data compressor.
freetype:x64-windows                               2.9.1-1          A library to render fonts.
freetype:x86-windows                               2.9.1-1          A library to render fonts.
fribidi:x64-windows                                58c6cb3          GNU FriBidi is an implementation of the Unicode ...
fribidi:x86-windows                                58c6cb3          GNU FriBidi is an implementation of the Unicode ...
harfbuzz:x64-windows                               2.4.0            HarfBuzz OpenType text shaping engine
harfbuzz:x86-windows                               2.4.0            HarfBuzz OpenType text shaping engine
harfbuzz[ucdn]:x64-windows                                          Builtin (UCDN) Unicode callbacks support
harfbuzz[ucdn]:x86-windows                                          Builtin (UCDN) Unicode callbacks support
libpng:x64-windows                                 1.6.37-1         libpng is a library implementing an interface fo...
libpng:x86-windows                                 1.6.37-1         libpng is a library implementing an interface fo...
libraqm:x64-windows                                0.5.0            A library for complex text layout
libraqm:x86-windows                                0.6.0            A library for complex text layout
ragel:x64-windows                                  6.10-1           Ragel State Machine Compiler
ragel:x86-windows                                  6.10-1           Ragel State Machine Compiler
zlib:x64-windows                                   1.2.11-5         A compression library
zlib:x86-windows                                   1.2.11-5         A compression library

So I'm a bit confused as to why glib is suddenly required.

@Neumann-A
Copy link
Contributor

hmm on which commit is your checkout of vcpkg compared to current master of vcpkg? Could be some recent change which introduced the target in one of those dependent targets.

@tobbi
Copy link
Contributor Author

tobbi commented May 29, 2019

I'm now on latest master. But even after rebasing, I can still build it fine. I rebuild every time with
vcpkg.exe remove libraqm && vcpkg.exe install libraqm

@Neumann-A
Copy link
Contributor

You have to rebuild vcpkg upgrade --no-dry-run or start clean by deleting the folders installed, buildtress and packages.

@tobbi
Copy link
Contributor Author

tobbi commented May 29, 2019

Even after running that command, the build still worked fine.

@Neumann-A
Copy link
Contributor

hmm tested it locally and it also worked. Try to retrigger CI by either pushing a whitespace change or merging current master

@tobbi
Copy link
Contributor Author

tobbi commented May 29, 2019

Done, let's see about the results.

@Neumann-A
Copy link
Contributor

Neumann-A commented May 29, 2019

hmm seems like CI is again partly broken (at least the Preview CI is already finished an giving the same errors as before). Lets wait for the real CI results ;)

@tobbi
Copy link
Contributor Author

tobbi commented May 29, 2019

Is the error message the same this time?

@vicroms
Copy link
Member

vicroms commented May 31, 2019

/azp run

@vicroms
Copy link
Member

vicroms commented Jun 3, 2019

CI keeps reporting failures on Windows, but I've been successful in installing it locally.
I'll take a look at what's causing the issues.

@vicroms
Copy link
Member

vicroms commented Jun 3, 2019

The dependency to unofficial::glib::glib can come from harfbuzz when some features are enabled. However, that's not the case when harfbuzz[ucdn] is installed, so more investigation is required.

For x64-windows-static I did notice a problem with fribidi, the library produces a libfribidi.a binary on Windows and libraqm seems unable to find it because of it.

@vicroms
Copy link
Member

vicroms commented Jun 7, 2019

/azp run

@vicroms
Copy link
Member

vicroms commented Jun 13, 2019

As of now, it passes on most platforms, but fails on x64-windows-static due to an issue withfribidi's meson build #6789.

I'm OK with merging this PR now and waiting for a new PR that addresses #6789 in the future.

@vicroms vicroms merged commit 9a24bd1 into microsoft:master Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants