[pcl] Fix cuda building compatability issues with cuda 10.1 #7388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good, have you passed this patch upstream to pcl? |
|
It was already fixed so no need to report up. I chose to apply the patch here instead of updating the version to point at the current HEAD for PCL. |
|
Okay so this patch was taken from upstream, but it's in an unreleased version of the code? |
|
Found the PR this patch is coming from, thanks for the PR! |
|
Little late on the response but yes. That is exactly it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issues building pcl with the cuda option related to upgrades to cuda 10.1