Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[proj4]Upgrade version to 6.1.1 and remove useless patches. #7917

Merged
merged 46 commits into from
Oct 18, 2019

Conversation

JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Aug 27, 2019

  1. Upgrade proj4 to v6.1.1
  2. Change the source to github.
  3. Add a new version of the dependency port sqlite3[tool].
  4. Remove useless patches.
  5. According to the official response, change the generated library name to proj.lib.
  6. Feature database need to install sqlite3:x86-windows/sqlite3:x64-windows on triplet arm/arm64/uwp.
  7. Fix the default library name of proj4 used by gdal.

Related: #3258 #3408 #6180 #6949..

@JackBoosY JackBoosY added the info:internal This PR or Issue was filed by the vcpkg team. label Aug 27, 2019
@microsoft microsoft deleted a comment from azure-pipelines bot Aug 27, 2019
@JackBoosY
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft microsoft deleted a comment from azure-pipelines bot Aug 27, 2019
@JackBoosY JackBoosY added the wip label Sep 9, 2019
@JackBoosY
Copy link
Contributor Author

Only have OSX failure here:

FAILED: bin/Debug/liblas.2.4.0.dylib 
: && /Library/Developer/CommandLineTools/usr/bin/c++ -fPIC  -Wextra -Wall -Wno-unused-parameter -Wno-unused-variable -Wpointer-arith -Wcast-align -Wcast-qual -Wfloat-equal -Wredundant-decls -Wno-long-long -g  -dynamiclib -Wl,-headerpad_max_install_names -compatibility_version 3.0.0 -current_version 2.4.0 -o bin/Debug/liblas.2.4.0.dylib -install_name @rpath/liblas.3.dylib src/CMakeFiles/las.dir/detail/index/indexcell.cpp.o src/CMakeFiles/las.dir/detail/index/indexoutput.cpp.o src/CMakeFiles/las.dir/chipper.cpp.o src/CMakeFiles/las.dir/factory.cpp.o src/CMakeFiles/las.dir/classification.cpp.o src/CMakeFiles/las.dir/color.cpp.o src/CMakeFiles/las.dir/dimension.cpp.o src/CMakeFiles/las.dir/error.cpp.o src/CMakeFiles/las.dir/filter.cpp.o src/CMakeFiles/las.dir/header.cpp.o src/CMakeFiles/las.dir/index.cpp.o src/CMakeFiles/las.dir/point.cpp.o src/CMakeFiles/las.dir/reader.cpp.o src/CMakeFiles/las.dir/spatialreference.cpp.o src/CMakeFiles/las.dir/schema.cpp.o src/CMakeFiles/las.dir/transform.cpp.o src/CMakeFiles/las.dir/utility.cpp.o src/CMakeFiles/las.dir/variablerecord.cpp.o src/CMakeFiles/las.dir/writer.cpp.o src/CMakeFiles/las.dir/version.cpp.o src/CMakeFiles/las.dir/detail/utility.cpp.o src/CMakeFiles/las.dir/detail/sha1.cpp.o src/CMakeFiles/las.dir/detail/zippoint.cpp.o src/CMakeFiles/las.dir/detail/reader/header.cpp.o src/CMakeFiles/las.dir/detail/reader/reader.cpp.o src/CMakeFiles/las.dir/detail/reader/zipreader.cpp.o src/CMakeFiles/las.dir/detail/reader/cachedreader.cpp.o src/CMakeFiles/las.dir/detail/writer/header.cpp.o src/CMakeFiles/las.dir/detail/writer/point.cpp.o src/CMakeFiles/las.dir/detail/writer/zipwriter.cpp.o src/CMakeFiles/las.dir/detail/writer/writer.cpp.o -L/Users/vagrant/azure_agent/_work/3/s/installed/x64-osx/debug/lib /Users/vagrant/azure_agent/_work/3/s/installed/x64-osx/debug/lib/libtiffd.a /Users/vagrant/azure_agent/_work/3/s/installed/x64-osx/debug/lib/liblzmad.a /Users/vagrant/azure_agent/_work/3/s/installed/x64-osx/debug/lib/libjpeg.a /Users/vagrant/azure_agent/_work/3/s/installed/x64-osx/debug/lib/libz.a -lm /Users/vagrant/azure_agent/_work/3/s/installed/x64-osx/debug/lib/libgeotiff.a /Users/vagrant/azure_agent/_work/3/s/installed/x64-osx/debug/lib/libboost_program_options.a /Users/vagrant/azure_agent/_work/3/s/installed/x64-osx/debug/lib/libboost_thread.a /Users/vagrant/azure_agent/_work/3/s/installed/x64-osx/debug/lib/libboost_system.a /Users/vagrant/azure_agent/_work/3/s/installed/x64-osx/debug/lib/libboost_iostreams.a /Users/vagrant/azure_agent/_work/3/s/installed/x64-osx/debug/lib/libboost_filesystem.a /Users/vagrant/azure_agent/_work/3/s/installed/x64-osx/debug/lib/libboost_chrono.a /Users/vagrant/azure_agent/_work/3/s/installed/x64-osx/debug/lib/libboost_date_time.a /Users/vagrant/azure_agent/_work/3/s/installed/x64-osx/debug/lib/libboost_atomic.a /Users/vagrant/azure_agent/_work/3/s/installed/x64-osx/debug/lib/libboost_regex.a /Users/vagrant/azure_agent/_work/3/s/installed/x64-osx/debug/lib/libtiffd.a /Users/vagrant/azure_agent/_work/3/s/installed/x64-osx/debug/lib/liblzmad.a -lproj /Users/vagrant/azure_agent/_work/3/s/installed/x64-osx/debug/lib/libjpeg.a /Users/vagrant/azure_agent/_work/3/s/installed/x64-osx/debug/lib/libz.a -lm && :
Undefined symbols for architecture x86_64:
  "_sqlite3_bind_double", referenced from:
      osgeo::proj::io::DatabaseContext::Private::run(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::list<osgeo::proj::io::SQLValues, std::__1::allocator<osgeo::proj::io::SQLValues> > const&) in libproj.a(factory.cpp.o)
  "_sqlite3_bind_text", referenced from:
      osgeo::proj::io::DatabaseContext::Private::run(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::list<osgeo::proj::io::SQLValues, std::__1::allocator<osgeo::proj::io::SQLValues> > const&) in libproj.a(factory.cpp.o)
  "_sqlite3_close", referenced from:
      osgeo::proj::io::DatabaseContext::Private::closeDB() in libproj.a(factory.cpp.o)
  "_sqlite3_column_count", referenced from:
      osgeo::proj::io::DatabaseContext::Private::run(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::list<osgeo::proj::io::SQLValues, std::__1::allocator<osgeo::proj::io::SQLValues> > const&) in libproj.a(factory.cpp.o)
  "_sqlite3_column_text", referenced from:
      osgeo::proj::io::DatabaseContext::Private::run(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::list<osgeo::proj::io::SQLValues, std::__1::allocator<osgeo::proj::io::SQLValues> > const&) in libproj.a(factory.cpp.o)
  "_sqlite3_create_function", referenced from:
      osgeo::proj::io::DatabaseContext::Private::registerFunctions() in libproj.a(factory.cpp.o)
  "_sqlite3_errmsg", referenced from:
      osgeo::proj::io::DatabaseContext::Private::run(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::list<osgeo::proj::io::SQLValues, std::__1::allocator<osgeo::proj::io::SQLValues> > const&) in libproj.a(factory.cpp.o)
  "_sqlite3_finalize", referenced from:
      osgeo::proj::io::DatabaseContext::Private::closeDB() in libproj.a(factory.cpp.o)
  "_sqlite3_open_v2", referenced from:
      osgeo::proj::io::DatabaseContext::Private::open(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, projCtx_t*) in libproj.a(factory.cpp.o)
      osgeo::proj::io::DatabaseContext::Private::attachExtraDatabases(std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > const&) in libproj.a(factory.cpp.o)
  "_sqlite3_prepare_v2", referenced from:
      osgeo::proj::io::DatabaseContext::Private::run(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::list<osgeo::proj::io::SQLValues, std::__1::allocator<osgeo::proj::io::SQLValues> > const&) in libproj.a(factory.cpp.o)
  "_sqlite3_reset", referenced from:
      osgeo::proj::io::DatabaseContext::Private::run(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::list<osgeo::proj::io::SQLValues, std::__1::allocator<osgeo::proj::io::SQLValues> > const&) in libproj.a(factory.cpp.o)
  "_sqlite3_result_double", referenced from:
      osgeo::proj::io::PROJ_SQLITE_pseudo_area_from_swne(sqlite3_context*, int, sqlite3_value**) in libproj.a(factory.cpp.o)
  "_sqlite3_result_int", referenced from:
      osgeo::proj::io::PROJ_SQLITE_intersects_bbox(sqlite3_context*, int, sqlite3_value**) in libproj.a(factory.cpp.o)
  "_sqlite3_result_null", referenced from:
      osgeo::proj::io::PROJ_SQLITE_pseudo_area_from_swne(sqlite3_context*, int, sqlite3_value**) in libproj.a(factory.cpp.o)
      osgeo::proj::io::PROJ_SQLITE_intersects_bbox(sqlite3_context*, int, sqlite3_value**) in libproj.a(factory.cpp.o)
  "_sqlite3_snprintf", referenced from:
      osgeo::proj::internal::toString(int) in libproj.a(internal.cpp.o)
      osgeo::proj::internal::toString(double, int) in libproj.a(internal.cpp.o)
  "_sqlite3_step", referenced from:
      osgeo::proj::io::DatabaseContext::Private::run(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::list<osgeo::proj::io::SQLValues, std::__1::allocator<osgeo::proj::io::SQLValues> > const&) in libproj.a(factory.cpp.o)
  "_sqlite3_value_double", referenced from:
      osgeo::proj::io::PROJ_SQLITE_GetValAsDouble(sqlite3_value*, bool&) in libproj.a(factory.cpp.o)
  "_sqlite3_value_int64", referenced from:
      osgeo::proj::io::PROJ_SQLITE_GetValAsDouble(sqlite3_value*, bool&) in libproj.a(factory.cpp.o)
  "_sqlite3_value_type", referenced from:
      osgeo::proj::io::PROJ_SQLITE_GetValAsDouble(sqlite3_value*, bool&) in libproj.a(factory.cpp.o)
  "_sqlite3_vfs_find", referenced from:
      osgeo::proj::io::DatabaseContext::Private::createCustomVFS() in libproj.a(factory.cpp.o)
      osgeo::proj::io::VFSClose(sqlite3_file*) in libproj.a(factory.cpp.o)
  "_sqlite3_vfs_register", referenced from:
      osgeo::proj::io::DatabaseContext::Private::createCustomVFS() in libproj.a(factory.cpp.o)
  "_sqlite3_vfs_unregister", referenced from:
      osgeo::proj::io::DatabaseContext::Private::~Private() in libproj.a(factory.cpp.o)
ld: symbol(s) not found for architecture x86_64

I don't have osx machine, can anyone help me?

@JackBoosY
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY
Copy link
Contributor Author

@dan-shaw I can't reproduce the qt5 component build failure on my machine. Can you test them?
If it is fake, this PR should be merged.

@JackBoosY JackBoosY removed the wip label Sep 18, 2019
@JackBoosY JackBoosY mentioned this pull request Sep 26, 2019
@dan-shaw dan-shaw requested a review from vicroms October 15, 2019 20:51
@dan-shaw
Copy link
Contributor

Besides the ports/sqlite3/CONTROL merge conflict, LGTM.

@JackBoosY
Copy link
Contributor Author

Already merged 9 times...OMG..

@cbezault
Copy link
Contributor

/azp run

1 similar comment
@dan-shaw
Copy link
Contributor

/azp run

@dan-shaw dan-shaw merged commit 75dd38c into microsoft:master Oct 18, 2019
@JackBoosY JackBoosY deleted the dev/jack/upgrade_proj4_6.1.1 branch October 18, 2019 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants