Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[liblas]Fix ${_IMPORT_PREFIX} in liblas-depends-*.cmake. #7920

Merged
merged 4 commits into from
Oct 8, 2019

Conversation

JackBoosY
Copy link
Contributor

Since liblas generates depends.cmake instead of target.cmake, fix ${_IMPORT_PREFIX} in these cmake files.

Related: #7749.

@JackBoosY JackBoosY added the info:internal This PR or Issue was filed by the vcpkg team. label Aug 27, 2019
@JackBoosY
Copy link
Contributor Author

@pwm1234 Can you test this?

Thanks.

@JackBoosY JackBoosY marked this pull request as ready for review August 27, 2019 09:14
@Neumann-A
Copy link
Contributor

@JackBoosY: This is a case for vcpkg_fixup_cmake_targets

  • either improve vcpkg_fixup_cmake_targets to incoparate the case of this port
  • or give vcpkg_fixup_cmake_targets an additional parameter like: TARGET_FILENAME which specifies the targetfile which needs to be fixed

@pwm1234
Copy link

pwm1234 commented Aug 28, 2019

Yes, I tested your change and the absolute path in the liblas-depends-release.cmake is gone!
Thank you!

@pwm1234
Copy link

pwm1234 commented Aug 28, 2019

By the way, if I try to build the release configuration only by putting set(VCPKG_BUILD_TYPE release) in my x64-linux.cmake triplets file, then I get this error:

-- Building x64-linux-rel
CMake Error at ports/liblas/portfile.cmake:41 (file):
  file COPY cannot find
  "/home/pmiller/pub/cpp/vcpkg-jackboosy/packages/liblas_x64-linux/debug/share/cmake/libLAS/liblas-depends-debug.cmake".
Call Stack (most recent call first):
  scripts/ports.cmake:85 (include)


Error: Building package liblas:x64-linux failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `.\vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: liblas:x64-linux
  Vcpkg version: 2019.08.23-unknownhash

Should be a new issue or can I tack it onto this one?

@JackBoosY
Copy link
Contributor Author

@pwm1234 Nope, I will fix it in this PR.

@JackBoosY JackBoosY added the wip label Aug 29, 2019
@JackBoosY JackBoosY removed the wip label Aug 29, 2019
@JackBoosY
Copy link
Contributor Author

@pwm1234 Could you re-test it? Thanks.

@vicroms vicroms merged commit 0de501a into microsoft:master Oct 8, 2019
@JackBoosY JackBoosY deleted the dev/jack/7749 branch October 9, 2019 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants