[VTK/GLEW] Fix Regression of VTK with newer CMake Versions #7967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The variables are required by ports like VTK
|
It should be a good idea to submit this patch to upstream cmake FindGLEW as well. |
|
Reported to CMake as https://gitlab.kitware.com/cmake/cmake/issues/19662 |
|
It failed with 'Download Build Artifacts' steps in linux testing, it's a temp issue, requeue it. |
|
@grdowns, could you priority to review and merge this PR? it blocked many people. |
|
Apologies for the wait! LGTM -- thanks everyone for the patience |
dennisklein
added a commit
to dennisklein/FairSoft
that referenced
this pull request
Jan 11, 2021
dennisklein
added a commit
to dennisklein/FairSoft
that referenced
this pull request
Jan 25, 2021
dennisklein
added a commit
to FairRootGroup/FairSoft
that referenced
this pull request
Jan 25, 2021
dennisklein
added a commit
to FairRootGroup/FairSoft
that referenced
this pull request
Jan 25, 2021
dennisklein
added a commit
to FairRootGroup/FairSoft
that referenced
this pull request
Feb 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer CMake Versions have a new Version of FindGLEW which loads just the config and forgets to define the common GLEW variables. The wrapper now takes care to add those variables back in. Should probably be fixed in either the GLEW configs or in CMakes FindGLEW since it promises to define those variables.