[libpng] Fix find_package() in CONFIG mode (#7968) #7972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malfrancis
pushed a commit
to moja-global/vcpkg
that referenced
this pull request
Sep 10, 2019
…t#7972) * Fix find_package(libpng CONFIG) * Fix typos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7968
The upstream
CMakeLists.txtfor libpng exports targets to a file namedlibpng16.cmake.However,
find_package(libpng CONFIG)expects a file namedlibpngConfig.cmaketo exist instead.In order for
find_package(libpng CONFIG)to work, we create a file with the proper name (libpngConfig.cmake) that includes the one generated by the build (libpng16.cmake).Note: CMake provides a module to find
libpngby callingfind_package(PNG).