Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sdl1]Support linux build. #8070

Merged
merged 5 commits into from
Sep 11, 2019
Merged

[sdl1]Support linux build. #8070

merged 5 commits into from
Sep 11, 2019

Conversation

JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Sep 6, 2019 •
edited
Loading

Related: #8060 #5813.

@JackBoosY JackBoosY added the info:internal This PR or Issue was filed by the vcpkg team. label Sep 6, 2019
@JackBoosY JackBoosY mentioned this pull request Sep 6, 2019
Merged
@cbezault cbezault self-assigned this Sep 6, 2019
@JackBoosY JackBoosY marked this pull request as ready for review September 6, 2019 07:27
cbezault
cbezault suggested changes Sep 6, 2019
View reviewed changes
ports/sdl1/portfile.cmake Outdated Show resolved Hide resolved
cbezault
cbezault suggested changes Sep 9, 2019
View reviewed changes
ports/sdl1/portfile.cmake Outdated Show resolved Hide resolved
ports/sdl1/portfile.cmake Outdated Show resolved Hide resolved
cbezault
cbezault suggested changes Sep 11, 2019
View reviewed changes
ports/sdl1/portfile.cmake Show resolved Hide resolved
@cbezault cbezault merged commit 87df659 into microsoft:master Sep 11, 2019
cbezault
cbezault reviewed Sep 11, 2019
View reviewed changes
Copy link
Contributor

@cbezault cbezault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@JackBoosY JackBoosY mentioned this pull request Dec 4, 2019
Merged
@JackBoosY JackBoosY deleted the dev/jack/sdl1_support_linux branch January 10, 2020 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CJCombrink CJCombrink CJCombrink left review comments

@cbezault cbezault cbezault requested changes

Assignees

@cbezault cbezault

Labels
info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JackBoosY @CJCombrink @cbezault