-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[osg]Fix windows-dynamic/linux build. #8060
Conversation
LLVM has copy file error, I cannot repro it on my machine. |
Attach osgstaticviewer compile log:
It should be:
|
osgText need fontconfg, fontconfig need expat, freetype, so ,when compiling osgText, linked fontconfig, expat, freetype, not only compile osgstaticviewer |
@ccliuyang right, but I can't solve the link libraries order problem yet. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@grdowns osg:x64-windows-static build success on my machine. |
@grdowns ping. |
@vicroms ready to merge now. |
@JackBoosY I can confirm that the |
/azp run |
LGTM, waiting for mac CI |
@CJCombrink Good idea, but it will take more time. This PR life is too long. |
Will fix p.s. osgearth is missing the dependencies to link against openssl, dl, fondconfig, expat, freetype, libpng, zlib, libbz2. |
/azp run |
Pull request contains merge conflicts. |
* [osg]Fix dynamic build. * [sdl1]Fix linux command. * [osg]Fix linux build: disable present3D and osgstaticview. * [osg]fix windows build-only for windows. * [osg]Fix file INSTALL error. * [osg]Add dependency conditions. * [osg]disable OSG_USE_UTF8_FILENAME in Linux and OSX. * [osg]Fix find dependency curl. Replace version num by macro. * [osg]Add option CMAKE_CXX_STANDARD * [osg] Remove library prefix. * [osg] Fix install pdbs * [osg] Remove usless plugin libs. * update baseline * update baseline * update baseline * update baseline
This PR added the patch file fix-builderror-with-libtiff.patch but it was not getting applied in the portfile. Let me know if it is still relevant and should be added to the portfile, otherwise I'll remove it as part of #20620. |
This PR will fix:
Related: #7996 #8184.
Fix curl cannot link with openssl
Fix osg cannot link with libxml2The component
present3D
has a dependency conflict with the componentosgstaticview
.Reason:
They all require port
expat
, but forosgstaticview
's dependent portfontconfig
, the library's link order must be fontconfig->freetype->expat. Sinceosg
's public dependency libraries is implemented using a list, the order ofexpat
is promoted to before thefontconfig
bypresent3D
, so theosgstaticview
build fails.After a variety of attempts, fixing this issue still failed. So I disabled these two components in linux temporary.