-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vcpkg] fatal_error when patch fails to apply #8087
Conversation
Quoting from previous pr:
edit: of course, any improvement that is necessary for the "green badge" is valid for this PR |
Wondering why a change in a common script does not trigger a whole rebuild? @Rastaban I will continue the work without the support of CI, which I was hoping to exploit |
…into dev/cenit/modernize
…into dev/cenit/modernize
bumping all the regressions, one by one in order to better understand the problems, was enough to solve most of them. A couple required some more attention and were fixed along the way. @vicroms, I think that this PR is now in the best possible situation for a merge: no regression, many many ports fixed along the way (new passes, yay), and patches/upgrades cannot be accepted anymore if they break a patch or do not apply them correctly (which was the specific target of this PR). |
I've reviewed all this files. It's a lot and so I might have missed something but it looks good to me. |
I'm still around just winding down. |
You cannot escape |
I will try my best for that to happen, locking you here inside monstrous PRs |
Continued work from #6578