Fix libyaml CMake package and CMake targets #8177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CMake exported targets and CMake package of libyaml were broken for the following reasons: * The CMake package of the port is called yaml, but the config files were installed in share/libyaml, so it was not possible for CMake's find_package command to find them * The CMake config file for the library is custom, so vcpkg_fixup_cmake_targets was not properly handling the change of CMake conf file directory from cmake to share/yaml. Use of the project's INSTALL_CMAKE_DIR option permitted to change easily also the custom part of the config file.
|
Just to clarify, before this PR a simple CMake project such as : project(sample-yaml-use)
find_package(yaml REQUIRED)
add_executable(main main.cpp)
target_link_libraries(main PRIVATE yaml)was broken, and now works correctly. |
Rastaban
approved these changes
Sep 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CMake exported targets and CMake package of libyaml were broken for the following reasons:
so it was not possible for CMake's find_package command to find them
the change of CMake conf file directory from cmake to share/yaml. Use of the project's INSTALL_CMAKE_DIR
option permitted to change easily also the custom part of the config file.