Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Qt] feature latest to build 5.13.1 #8212

Merged
merged 3 commits into from
Sep 23, 2019
Merged

[Qt] feature latest to build 5.13.1 #8212

merged 3 commits into from
Sep 23, 2019

Conversation

Neumann-A
Copy link
Contributor

Default-Features: latest will be removed after CI run

@Neumann-A
Copy link
Contributor Author

@cbezault @Rastaban. Just informational pinging due to updated and new PR replacing #8189

@JackBoosY JackBoosY self-assigned this Sep 17, 2019
@Rastaban Rastaban self-assigned this Sep 17, 2019
@cbezault
Copy link
Contributor

You should be able to trigger this behavior off of VCPKG_USE_HEAD_VERSION instead of making it a feature (I understand if you're doing the feature thing just to test it in our CI).

@Rastaban
Copy link
Contributor

VCPKG_USE_HEAD_VERSION is set when passing vcpkg the --head option.

@Neumann-A
Copy link
Contributor Author

@Rastaban @cbezault:
If I do vcpkg install qt5 --head: Is VCPKG_USE_HEAD_VERSION really also set in the build of qt5-base? I don't think so since propagating --head into the dependent ports feels like a really wrong thing to do. (although i did not try it out. But If it does I would certainly assume thats a bug)

Neumann-A
Neumann-A commented Sep 17, 2019
View reviewed changes
ports/qt5-base/CONTROL Outdated Show resolved Hide resolved
@Rastaban
Copy link
Contributor

@Neumann-A I think your right, --head would not be propagated. In that case the feature route is really the only option.

@Neumann-A Neumann-A marked this pull request as ready for review September 18, 2019 07:27
cbezault
cbezault approved these changes Sep 23, 2019
View reviewed changes
Copy link
Contributor

@cbezault cbezault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rastaban Rastaban merged commit 7ca4891 into microsoft:master Sep 23, 2019
@maksqwe maksqwe mentioned this pull request Oct 1, 2019
Closed
@Neumann-A Neumann-A mentioned this pull request Nov 5, 2019
Closed
@Neumann-A Neumann-A deleted the qt_feature_latest branch November 18, 2020 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rastaban Rastaban Rastaban left review comments

@cbezault cbezault cbezault approved these changes

Assignees

@Rastaban Rastaban

@JackBoosY JackBoosY

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Neumann-A @cbezault @Rastaban @JackBoosY