Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libevent] Fix include headers fails on x64-windows, using CMAKE #9292

Merged
merged 4 commits into from
Jan 6, 2020
Merged

[libevent] Fix include headers fails on x64-windows, using CMAKE #9292

merged 4 commits into from
Jan 6, 2020

Conversation

AlvinZhangH
Copy link
Contributor

Related issue #9275.

  1. fix LibeventConfig.cmake.in path
  2. Delete deprecated functions
  3. Update deprecated functions

All Features of this port install ok on triplet x86-windows, x64-windows, x64-linux.

@AlvinZhangH AlvinZhangH added the info:internal This PR or Issue was filed by the vcpkg team. label Dec 12, 2019
@AlvinZhangH AlvinZhangH marked this pull request as ready for review January 3, 2020 07:36
@AlvinZhangH
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Pull request contains merge conflicts.

JackBoosY
JackBoosY suggested changes Jan 6, 2020
View reviewed changes
Copy link
Contributor

@JackBoosY JackBoosY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update version in CONTROL?

@AlvinZhangH
Copy link
Contributor Author

@JackBoosY Already updated the version.

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Jan 6, 2020
@dan-shaw dan-shaw merged commit a00a345 into microsoft:master Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackBoosY JackBoosY JackBoosY approved these changes

Assignees

@JackBoosY JackBoosY

Labels
info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlvinZhangH @JackBoosY @dan-shaw