Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[boost] Update to 1.72.0 #9317

Merged
merged 27 commits into from
Jan 16, 2020
Merged

[boost] Update to 1.72.0 #9317

merged 27 commits into from
Jan 16, 2020

Conversation

yurybura
Copy link
Contributor

@yurybura yurybura commented Dec 14, 2019 •
edited

Update Boost libarary to 1.72.0:

  • generate-ports.ps1 script was modified to support new version and was run to re-generate related ports;
  • boost-python was fixed to find Python3 even Python2 port is installed.

Fixes issue #9298 #6310

@yurybura
[boost-python] Support Python2 as feature, fix build with installed P…
3d88912 
…ython2
@yurybura
[boost-python] Update generate script to support Python2 mod
730f942
@yurybura
Merge branch 'master' of https://github.com/microsoft/vcpkg
b971c4c
@yurybura
Re-generate boost ports
456699e
@yurybura
[boost-modular-build-helper] Update to 1.71.
b26d098 
[boost-build] Update to 1.71.
@yurybura
Merge branch 'master' of https://github.com/microsoft/vcpkg
479b6b2
@yurybura
[boost-modular-build-helper] Remove manual library name changing
abd8071 
[boost-iostreams] Use boost-modular-headers.cmake script
@yurybura
Delete temporary file.
4c27dc9
@yurybura
Merge branch 'master' of https://github.com/microsoft/vcpkg
cf502b5
@yurybura
Merge branch 'master' of https://github.com/microsoft/vcpkg
6ce15c0
@yurybura
Revert changes in modular build script.
6d796ce
@yurybura
Update ports versions.
f65250f
@yurybura
Merge branch 'master' of https://github.com/microsoft/vcpkg
54f5051
@yurybura
[boost-modular-build-helper] Fix build boost-iostreams with LZMA and …
302089a 
…ZSTD
@yurybura
Merge branch 'master' of https://github.com/microsoft/vcpkg
a48e2dc
@yurybura
[boost] Update to 1.72.0
d536a00
cenit
cenit reviewed Dec 15, 2019
View reviewed changes
Copy link
Contributor

@cenit cenit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also edit the generate-ports.ps1 to remove include(vcpkg_common_functions)

ports/boost-python/portfile.cmake Outdated Show resolved Hide resolved
scripts/boost/post-source-stubs/python.cmake Outdated Show resolved Hide resolved
@yurybura
[libtorrent] Fix build with Boost 1.72.0
fdaa748 
Original PR: arvidn/libtorrent#4091
@yurybura
Update ci.baseline.txt:
c25bb3f 
- fail libgo:* due to use the removed class from Boost.Context 1.72.0 (reported issue yyzybb537/libgo#214)
- pass boost-context:arm64-windows
- fix typo
@yurybura
Folly only supports the x64 architecture
0148da7
@yurybura
fail boost-coroutine:arm64-windows=fail and boost-fiber:arm64-windows…
9e05068 
…=fail because they use fcontext_t from Boost.Context which is not implemented for Windows on ARM64 (reported issue boostorg/context#130)
@yurybura
Fix globbing-expressions
4accb82
@yurybura
Copy link
Contributor Author

This means that libgo is not buildable anymore in any os nor any config?

Temporary yes, this library is not compatible with Boost.Context 1.72.0.

@yurybura yurybura marked this pull request as ready for review December 15, 2019 20:11
@PhoebeHui PhoebeHui mentioned this pull request Dec 16, 2019
Closed
PhoebeHui
PhoebeHui approved these changes Dec 16, 2019
View reviewed changes
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Dec 16, 2019
ras0219-msft
ras0219-msft requested changes Dec 19, 2019
View reviewed changes
ports/boost-system/portfile.cmake Outdated Show resolved Hide resolved
scripts/boost/generate-ports.ps1 Show resolved Hide resolved
@PhoebeHui
Copy link
Contributor

Related to #8372

@JackBoosY
Copy link
Contributor

/azp run

@JackBoosY
Copy link
Contributor

/azp run

@dan-shaw
Copy link
Contributor

dan-shaw commented Jan 6, 2020

/azp run

@yurybura
Copy link
Contributor Author

yurybura commented Jan 6, 2020

Dear @dan-shaw, CI was failed with empty log,.. could you help to investigate the reason?

@JackBoosY
Copy link
Contributor

/azp run

1 similar comment
@dan-shaw
Copy link
Contributor

dan-shaw commented Jan 9, 2020

/azp run

@dan-shaw
Copy link
Contributor

dan-shaw commented Jan 9, 2020

Should work now

@ras0219-msft
Copy link
Contributor

/azp run

2 similar comments
@ras0219-msft
Copy link
Contributor

/azp run

@JackBoosY
Copy link
Contributor

/azp run

@yurybura
Copy link
Contributor Author

Finally all checks have done. Please merge or request changes. Thanks a lot.

@vicroms
Copy link
Member

vicroms commented Jan 16, 2020

Thanks for the PR!

@vicroms vicroms merged commit c50852a into microsoft:master Jan 16, 2020
This was referenced Jan 17, 2020
Closed
Closed
Merged
@yurybura yurybura mentioned this pull request May 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cenit cenit cenit left review comments

@ras0219-msft ras0219-msft ras0219-msft requested changes

@PhoebeHui PhoebeHui PhoebeHui approved these changes

Assignees

@JackBoosY JackBoosY

@dan-shaw dan-shaw

Labels
info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@yurybura @PhoebeHui @JackBoosY @dan-shaw @ras0219-msft @vicroms @cenit