Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libusb] Fix issue to support linux #9561

Merged
merged 13 commits into from Jul 29, 2020

Conversation

PhoebeHui
Copy link
Contributor

Fix related issue #9560

libusb support linux, and actually it doesn't support uwp.
Linux supported and this issue involved by commit 47d206

@PhoebeHui PhoebeHui added the info:internal This PR or Issue was filed by the vcpkg team. label Jan 6, 2020
@PhoebeHui PhoebeHui changed the title [libusb] fix issue to support linux [libusb] Fix issue to support linux Jan 6, 2020
@cenit
Copy link
Contributor

cenit commented Jan 6, 2020

I still kept the build "blocked" on linux because it was triggering failures on other ports when found. Maybe it's time to fix them :)

@JackBoosY JackBoosY self-requested a review January 7, 2020 02:17
@PhoebeHui PhoebeHui added the wip label Jan 10, 2020
@PhoebeHui
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@strega-nil strega-nil marked this pull request as draft May 21, 2020 21:51
@JackBoosY JackBoosY added the category:port-bug The issue is with a library, which is something the port should already support label Jun 11, 2020
@PhoebeHui
Copy link
Contributor Author

libusb:x64-linux and libusb:x64-osx currrently clean, the failed ports which depend on libusb doesn't relate to this changes, so I set them failed temproraily in ci baseline file for unblocking this PR. I will summit seperate PRs to fix these failures.

treehopper:x64-linux
azure-kinect-sensor-sdk:x64-linux
libfreenect2:x64-linux
azure-kinect-sensor-sdk:x64-osx
libfreenect2:x64-osx

@PhoebeHui PhoebeHui marked this pull request as ready for review June 19, 2020 08:03
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Jun 19, 2020
@cenit
Copy link
Contributor

cenit commented Jul 1, 2020

the failed ports which depend on libusb doesn't relate to this changes

why do you say so?

@PhoebeHui
Copy link
Contributor Author

@cenit, the libusb failed on linux before, so these ports which depend on it haven't been test, and they failed before, so it's not a regression issue involved by this PR, they need seperate PRs to support/unsupport on linux.

@strega-nil
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@strega-nil strega-nil merged commit a2d3782 into microsoft:master Jul 29, 2020
hellozee pushed a commit to hellozee/vcpkg that referenced this pull request Sep 11, 2020
* [libusb] support linux

* Add Supports

* Using vcpkg_configure_make instead

* Revert to install headers in windows

* Fix failures in libftd1

* Update treehopper

* Add failed ports in ci baseline file

* Revert to remove azure-kinect-sensor-sdk:x64-windows-static=fail in baseline file

* Resolve conflicts

Co-authored-by: PhoebeHui <v-phma@microsoft.com>
@PhoebeHui PhoebeHui deleted the dev/Phoebe/libusb branch October 22, 2020 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants