Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libfreenect2] add opengl and opencl features #9551

Merged
merged 2 commits into from
Jan 6, 2020

Conversation

lyhyl
Copy link
Contributor

@lyhyl lyhyl commented Jan 4, 2020

Describe the pull request

  • What does your PR fix? Fixes issue [libfreenect2] need opengl, opencl, cuda support #9540

  • Which triplets are supported/not supported? Have you updated the CI baseline?
    Only x64-windows was tested.
    Due to nvcc's limitation: "nvcc fatal : 32 bit compilation is only supported for Microsoft Visual Studio 2013 and earlier", so I cannot compile x86-windows.

  • Does your PR follow the maintainer guide?
    Yes

@msftclas
Copy link

msftclas commented Jan 4, 2020

CLA assistant check
All CLA requirements met.

@lyhyl lyhyl marked this pull request as ready for review January 4, 2020 08:04
@lyhyl
Copy link
Contributor Author

lyhyl commented Jan 5, 2020

Do we have to support all triplets?
32-bit support is gradually being deprecated/removed from CUDA. x86-windows is not supported.

@lyhyl lyhyl changed the title add opengl, opencl and cuda features for libfreenect2 [libfreenect2] add opengl, opencl and cuda features Jan 5, 2020
@lyhyl lyhyl changed the title [libfreenect2] add opengl, opencl and cuda features [libfreenect2] add opengl and opencl features Jan 5, 2020
@PhoebeHui
Copy link
Contributor

@lyhyl, Feature opengl and opencl tested pass with x86-windows, x64-windows on my test machine.

It failed on linux without the 2 features, so this change looks not involve in regressions.

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Jan 6, 2020
@lyhyl
Copy link
Contributor Author

lyhyl commented Jan 6, 2020

@lyhyl, Feature opengl and opencl tested pass with x86-windows, x64-windows on my test machine.

It failed on linux without the 2 features, so this change looks not involve in regressions.

Thanks, I will try on linux environment.

@lyhyl
Copy link
Contributor Author

lyhyl commented Jan 6, 2020

After my test, I found that it was libusb that caused the failure. At the same time, I was surprised to find that @PhoebeHui you are fixing it(#9561). And I also learned about CI baseline. Thanks!

@dan-shaw dan-shaw merged commit fe62406 into microsoft:master Jan 6, 2020
@dan-shaw
Copy link
Contributor

dan-shaw commented Jan 6, 2020

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants