-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ms-gsl] Update to v2.1.0, the "end of 2019 snapshot" #9624
Conversation
@Farwaykorse, thanks for the PR! The CI failed with following regression, is this expected? could you take a look? |
@PhoebeHui Thanks for checking. This is indeed unexpected. |
Added the fix. |
@PhoebeHui @Farwaykorse Thanks for letting me know the issue :) |
/azp run |
All the CI errors look to be unrelated to this PR; no changes needed |
/azp run |
The CI failed with '##[error] REGRESSION: qt5-tools:x86-windows' it seems not related to this changes:
|
Needs to rerun pipeline test after #9752 merged. |
The CI test pass, it seems no issue block this PR. |
Thanks for the PR! |
Changes for v2.1.0.
Didn't update to the current HEAD, because not all CI builds are succeeding on Linux.
(The testsuite of the GSL is being migrating from Catch to GTest.)
include(vcpkg_common_functions)
.Updated with a fix (add missing #include <cassert> luncliff/coroutine#45) required to build with recent versions of the GSL.
No changes.