Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[boost-python] Try to fix build issue on Linux #9780

Merged
merged 10 commits into from
Mar 2, 2020
Merged

[boost-python] Try to fix build issue on Linux #9780

merged 10 commits into from
Mar 2, 2020

Conversation

yurybura
Copy link
Contributor

@yurybura yurybura commented Jan 21, 2020

This PR allows install and use Python3 dependency on Linux and OSX.

Fixes #9824 #9764 #4962

@yurybura yurybura marked this pull request as ready for review January 21, 2020 09:28
@PhoebeHui PhoebeHui self-assigned this Jan 22, 2020
@PhoebeHui
Copy link
Contributor

@yurybura, the CI on linux passed due to 'boost-python:x64-linux=ignore' added to https://github.com/microsoft/vcpkg/blob/master/scripts/ci.baseline.txt#L164, could you please remove it from ci baseline?

@yurybura
Copy link
Contributor Author

@PhoebeHui boost_modular_build() doesn't configure Python on Linux. Let me try to fix it first. Please add WIP label for this PR. Thanks.

@PhoebeHui
Copy link
Contributor

@yurybura, added, thanks for taking look at this issue!

@yurybura
Copy link
Contributor Author

Dear @PhoebeHui, could you start reviewing of this PR? I have just finished fixing this issue.

I think Boost's CMake scripts should be reworked to merge in one for all platforms in separate PR...

@yurybura
Copy link
Contributor Author

Build bot has failed but this fail isn't related to my changes... CI quite unstable again.

@adamvm
Copy link

adamvm commented Feb 2, 2020

@yurybura ready :) I tested after git pull and ./vcpkg install boost including boost-python finished successfully. Thank you

@yurybura
Copy link
Contributor Author

yurybura commented Feb 2, 2020

@adamvm Thank you.
@PhoebeHui Please start review of this PR.

Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yurybura, thanks for the updates!

@PhoebeHui
Copy link
Contributor

@ras0219-msft, could you help review?

Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zlojvavan
Copy link

how to apply the fix?

@PhoebeHui
Copy link
Contributor

@ras0219-msft, could you priority to review this PR?

@yurybura
Copy link
Contributor Author

yurybura commented Mar 1, 2020

@PhoebeHui, @strega-nil, @ras0219-msft
Ping. Please have a look this PR.

@strega-nil
Copy link
Contributor

I'm happy with this! Thanks @yurybura, this is really awesome :)

@strega-nil strega-nil merged commit 1c414f9 into microsoft:master Mar 2, 2020
@strega-nil strega-nil mentioned this pull request Mar 2, 2020
@yurybura yurybura deleted the fix-boost-python-on-linux branch March 2, 2020 19:57
@cenit
Copy link
Contributor

cenit commented Mar 4, 2020

Hi! Thanks for the PR, but... boost-python was broken on Linux but still is... at least for me.
Installing the python3 dependency fails with an error message telling the dev that to build out of tree the source must be clean (at install phase). Of course, buildtrees folder was removed before installing.

@yurybura
Copy link
Contributor Author

yurybura commented Mar 4, 2020

@cenit, looks like it is a python3 port issue. Could you report a separate bug report for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[<boost-python:x64-linux>] build failure
7 participants