-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[boost-python] Try to fix build issue on Linux #9780
[boost-python] Try to fix build issue on Linux #9780
Conversation
@yurybura, the CI on linux passed due to 'boost-python:x64-linux=ignore' added to https://github.com/microsoft/vcpkg/blob/master/scripts/ci.baseline.txt#L164, could you please remove it from ci baseline? |
@PhoebeHui |
@yurybura, added, thanks for taking look at this issue! |
Dear @PhoebeHui, could you start reviewing of this PR? I have just finished fixing this issue. I think Boost's CMake scripts should be reworked to merge in one for all platforms in separate PR... |
Build bot has failed but this fail isn't related to my changes... CI quite unstable again. |
…ra/vcpkg into fix-boost-python-on-linux
…boost-python-on-linux
@yurybura ready :) I tested after git pull and ./vcpkg install boost including boost-python finished successfully. Thank you |
@adamvm Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yurybura, thanks for the updates!
@ras0219-msft, could you help review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…boost-python-on-linux
how to apply the fix? |
@ras0219-msft, could you priority to review this PR? |
@PhoebeHui, @strega-nil, @ras0219-msft |
I'm happy with this! Thanks @yurybura, this is really awesome :) |
Hi! Thanks for the PR, but... boost-python was broken on Linux but still is... at least for me. |
@cenit, looks like it is a python3 port issue. Could you report a separate bug report for this? |
This PR allows install and use Python3 dependency on Linux and OSX.
Fixes #9824 #9764 #4962