Generic sanitizer run on CI #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change USE_ASAN option to SANITIZER, so that we can choose any sanitizer to run on local builds or CI. Runs ASAN on both commit CI and nightly, so we can catch errors earlier. Not running UBSAN yet because some errors in the parser are still failing and there may be some spurious run-time errors that need fixing before turning it on. But from this commit onwards, anyone can use any sanitizer (even combining them with -DSANITIZER="address,undefined,leak") on a local build for all programs, not just ASAN on the run-time.
rengolin
force-pushed
the
sanitizer-builds
branch
from
2182d3f
to
8b5749c
Compare
|
Passed nightly on Linux and Windows. Mac is still breaking but that's unrelated to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change USE_ASAN option to SANITIZER, so that we can choose any sanitizer
to run on local builds or CI.
Runs ASAN on both commit CI and nightly, so we can catch errors earlier.
Not running UBSAN yet because some errors in the parser are still
failing and there may be some spurious run-time errors that need fixing
before turning it on.
But from this commit onwards, anyone can use any sanitizer (even
combining them with -DSANITIZER="address,undefined,leak") on a local
build for all programs, not just ASAN on the run-time.