Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic proxies should implement void returning methods by sending notifications #522

Closed
AArnott opened this issue Aug 12, 2020 · 0 comments · Fixed by #526
Closed

Dynamic proxies should implement void returning methods by sending notifications #522

AArnott opened this issue Aug 12, 2020 · 0 comments · Fixed by #526
Assignees
@AArnott
Labels
enhancement
Milestone
v2.6

Comments

@AArnott
Copy link
Member

AArnott commented Aug 12, 2020

The dynamic proxies reject interfaces that define void-returning methods today.
We need to support them and implement them by sending JSON-RPC notifications in order to support IObserver<T> (#346).
@AArnott AArnott added this to the v2.6 milestone Aug 12, 2020
@AArnott AArnott self-assigned this Aug 12, 2020
@AArnott AArnott mentioned this issue Aug 12, 2020
Closed
6 tasks
AArnott added a commit to AArnott/vs-streamjsonrpc that referenced this issue Aug 13, 2020
@AArnott
Add support for void returning methods in RPC interfaces
c3e5e80 
Dynamically generated RPC proxies implement void-returning methods by sending a notification instead of a request.

Closes microsoft#522
@AArnott AArnott mentioned this issue Aug 13, 2020
Merged
@AArnott AArnott mentioned this issue Sep 3, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AArnott AArnott

Labels
enhancement
Projects
None yet
Milestone
v2.6
Development

Successfully merging a pull request may close this issue.

Add support for void returning methods in RPC interfaces AArnott/vs-streamjsonrpc
1 participant
@AArnott