Fix ETW logging of named arguments in System.Text.Json formatter #1040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…em.Text.Json` formatter This also adjusts how we test with ETW events turned on so that issues like this will be caught rather than swallowed. Fixes microsoft#1038
dibarbet
approved these changes
May 7, 2024
RyanToth3
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TryGetArgumentByNameOrIndexwhen using theSystem.Text.JsonformatterThis also adjusts how we test with ETW events turned on so that issues like this will be caught rather than swallowed.
Fixes SystemTextJsonFormatter throws exceptions when ETW logging is enabled #1038