Fix activity tracing to track entire execution time of inbound calls #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankitvarmait
approved these changes
Jan 29, 2022
Codecov Report
@@ Coverage Diff @@
## main #763 +/- ##
==========================================
+ Coverage 91.54% 91.75% +0.20%
==========================================
Files 60 61 +1
Lines 5182 5323 +141
==========================================
+ Hits 4744 4884 +140
- Misses 438 439 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The incoming RPC was getting an activity that bound only the time to invoke the server method and get its result back. But if the method were async, terminating the activity at that point meant the timestamp on the end of the activity would be premature. Instead, an async server method should mean the activity does not end until the returned Task completes. This makes it clear that child activities and other messages logged by the server method belong to that activity.
As shown in the Service Trace Viewer:
Before
After
