Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CompilationEnd tag to VSTHRD010 analyzer #1114

Merged
merged 1 commit into from
Nov 21, 2022

Conversation

AArnott
Copy link
Member

@AArnott AArnott commented Nov 21, 2022

Fixes #1113

@AArnott AArnott added this to the v17.4 milestone Nov 21, 2022
Copy link
Member

@mavasani mavasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Is this the only analyzer that has compilation end diagnostics?

@AArnott
Copy link
Member Author

AArnott commented Nov 21, 2022

Yes it is, @mavasani. Thank you for your review.

@AArnott AArnott merged commit ccb3fd2 into microsoft:v17.4 Nov 21, 2022
@AArnott AArnott deleted the fix1113 branch November 21, 2022 15:58
@mavasani
Copy link
Member

mavasani commented Jan 2, 2023

@AArnott This was reported by a customer in https://developercommunity.visualstudio.com/t/Error-List-warnings-disappears-when-file/10235352. Can you please update that feedback ticket with information about newer analyzer NuGet package with this fix?

@AArnott
Copy link
Member Author

AArnott commented Jan 3, 2023

Done, @mavasani.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants