Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WellKnownDiagnosticTags.CompilationEnd for compilation end diagnostic descriptors #1113

Closed
mavasani opened this issue Nov 21, 2022 · 1 comment
Closed

Add WellKnownDiagnosticTags.CompilationEnd for compilation end diagnostic descriptors #1113

mavasani opened this issue Nov 21, 2022 · 1 comment
Assignees
@AArnott
Labels
analyzers bug
Milestone
v17.4

Comments

@mavasani
Copy link

Bug description

DiagnosticDescriptor for diagnostics reported in compilation end action should have WellKnownDiagnosticTags.CompilationEnd. See dotnet/roslyn#65304 (comment) for details.

Repro steps

See dotnet/roslyn#65304 for details.
@mavasani mavasani mentioned this issue Nov 21, 2022
Closed
@AArnott AArnott self-assigned this Nov 21, 2022
AArnott added a commit to AArnott/vs-threading that referenced this issue Nov 21, 2022
@AArnott
Add CompilationEnd tag to VSTHRD010 analyzer
3a53dfd 
Fixes microsoft#1113
@AArnott AArnott mentioned this issue Nov 21, 2022
Merged
@AArnott AArnott added this to the v17.4 milestone Jan 3, 2023
@AArnott
Copy link
Member

AArnott commented Jan 3, 2023

The fix for this is available in our 17.4.33 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AArnott AArnott

Labels
analyzers bug
Projects
None yet
Milestone
v17.4
Development

No branches or pull requests
2 participants
@AArnott @mavasani