Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Extract/Publish mechanism from APIOps to this extension #325

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Add Extract/Publish mechanism from APIOps to this extension #325

wants to merge 7 commits into from

Conversation

ross-p-smith
Copy link

@ross-p-smith ross-p-smith commented Aug 16, 2023 •
edited
Loading

This PR is open for comment about the direction to take for adding APIOps capability to this extension.

  • I have left the old 'extract ARM' functionality there although I believe it should be removed as it depends on .Net 2.1 and the DevOps Toolkit itself is deprecated.
  • I have added a DevContainer for ease of development
  • I download the 2 binaries required for import/export when the Extension is first activated as this reduces the size by 140Mb.

Things yet to do

  • Feature flag hide the old functionality

Relates to #324

@ross-p-smith
Copy link
Author

When you first invoke the extension, it will download binaries in the background
image

@ross-p-smith
Copy link
Author

ross-p-smith commented Aug 30, 2023 •
edited
Loading

Two new menu items (APIOps) to extract and publish
image

Extract Service is the older DevOps Toolkit version that requires .Net 2.1 installed to work.

quanterion
quanterion reviewed Sep 1, 2023
View reviewed changes
src/utils/vscodeUtils.ts Outdated Show resolved Hide resolved
@quanterion
Copy link
Contributor

LGTM. Just general remark is looks like APIOps support exporting just spec (like OpenApi for REST) and we need to add new APIs like OData there

@ross-p-smith
Copy link
Author

Currently ApiOps only supports specifications, not OData endpoints - I have raised the following issue to track this: - Azure/apiops#419

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeagleGross DeagleGross Awaiting requested review from DeagleGross

@quanterion quanterion Awaiting requested review from quanterion

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ross-p-smith @quanterion