utils: Add implementation for showWorkspaceFolderPick
#1734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwateratmsft
previously approved these changes
May 30, 2024
MicroFish91
changed the title
showWorkspaceFolderPick to AzExtUserInputshowWorkspaceFolderPick
…into mwf/showWorkspaceFolderPick
MicroFish91
force-pushed
the
mwf/showWorkspaceFolderPick
branch
from
f65eda8
to
a2cf8b8
Compare
nturinski
approved these changes
Jun 3, 2024
alexweininger
approved these changes
Jun 3, 2024
| * @throws `UserCancelledError` if the user cancels. | ||
| * @returns A promise that resolves to the selected `WorkspaceFolder`. | ||
| */ | ||
| showWorkspaceFolderPick(options: AzExtWorkspaceFolderPickOptions): Promise<WorkspaceFolder>; |
There was a problem hiding this comment.
Does it make more sense to name it showWorkspaceFolderPicker? Is it a pick or a picker? This is a nit, I'm mostly asking and not asking for a change.
There was a problem hiding this comment.
Picker is potentially a better name, but I was thinking to just keep the name mirrored with its VS Code analogue => vscode.window.showWorkspaceFolderPick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on publishing the
devpackage first, see this