Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use product icons instead of 'hardcoded' icons #3737

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

DeltaRazero
Copy link

This changes themability

The following changes are proposed/purpose of the changes:

  • Add a product icon font instead of 'hardcoded' icons. This has the following benefits:
    • Product icon themes can now override the icons if desired
    • Color themes can now properly set the colors of the icons, so no need to maintain light and dark icons that are not following the theme's colors.
  • Add a script using FontForge scripting API for generating product icon font for future use
    • I feel like FontForge is a good cross-platform open source platform to use as font generator. It is robust and it doesn't require a separate installation of Python to invoke the scripting API (i.e. FontForge bundles its own Python runtime).
    • The inclusion of the script is purely for future use if more icons are needed
    • Filenames of icons now include the glyph codepoint so it's easier to see what the codepoint is for each icon, as well as the script uses this for mapping the icons to the desired codepoints.
  • Remove redundant icons that are already part of codicons; change the package.json to use the already present codicons

Furthermore, I centered the build icon as it was off-center.

- Add a product icon font instead of icons that are unchangable by product icon themes
- Add a script using FontForge scripting API for generating product icon font for future use
- Remove redundant icons that are already part of codicons
@DeltaRazero
Copy link
Author

@microsoft-github-policy-service agree

@DeltaRazero
Copy link
Author

@gcampbell-msft Could you kindly provide me with feedback or a comment please? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant