Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show specificity in a css selector hover. #129

Merged
merged 7 commits into from
Oct 29, 2018

Conversation

Ragnoroct
Copy link
Contributor

This is a pull request to show the specificity score of a css selector on hover.

@msftclas
Copy link

msftclas commented Oct 25, 2018

CLA assistant check
All CLA requirements met.

@Ragnoroct
Copy link
Contributor Author

Ragnoroct commented Oct 25, 2018

I'm kind of new to this. How do I reference microsoft/vscode#7299 with this pull request while I'm working on it?

EDIT: Ahhh. I guess I did it indirectly. 😄

@Ragnoroct
Copy link
Contributor Author

I can fix the unit tests Saturday morning.

@Ragnoroct Ragnoroct changed the title WIP: First attempt at showing specificity in a css selector hover. Show specificity in a css selector hover. Oct 27, 2018
@Ragnoroct
Copy link
Contributor Author

@aeschli I'm finished with this and all the tests pass. Do I need to do anything else to get this into vscode?

kumarharsh and others added 2 commits October 28, 2018 15:46
Co-Authored-By: Ragnoroct <willypbender83@gmail.com>
Co-Authored-By: Ragnoroct <willypbender83@gmail.com>
@Ragnoroct
Copy link
Contributor Author

@kumarharsh Thank you. I've applied your suggested code changes to fix the typos.

@aeschli
Copy link
Contributor

aeschli commented Oct 29, 2018

Very cool, thanks, @Ragnoroct !

@aeschli aeschli merged commit 962cad6 into microsoft:master Oct 29, 2018
@aeschli aeschli added this to the October 2018 milestone Oct 29, 2018
@aeschli
Copy link
Contributor

aeschli commented Oct 29, 2018

I made some minor improvements: 0bba3ee

@alicercedigital
Copy link

How can we hide this popup?

@aeschli
Copy link
Contributor

aeschli commented Jul 18, 2024

You can turn off all css hovers, if you want:

  "[css]": {
    "editor.hover.enabled": false
  },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants