Skip to content

Commit

Permalink
revert /pull/83
Browse files Browse the repository at this point in the history
  • Loading branch information
weinand committed Nov 15, 2016
1 parent 9075996 commit 206c57f
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 19 deletions.
4 changes: 2 additions & 2 deletions adapter/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "vscode-debugadapter",
"description": "Debug adapter implementation for node",
"version": "1.15.0-pre.2",
"version": "1.15.0-pre.3",
"author": "Microsoft Corporation",
"license": "MIT",
"repository": {
Expand All @@ -14,7 +14,7 @@
"main": "./lib/main.js",
"typings": "./lib/main",
"dependencies": {
"vscode-debugprotocol": "^1.15.0-pre.2"
"vscode-debugprotocol": "^1.15.0-pre.3"
},
"devDependencies": {
"typescript": "^1.8.10"
Expand Down
3 changes: 0 additions & 3 deletions adapter/src/debugSession.ts
Original file line number Diff line number Diff line change
Expand Up @@ -535,9 +535,6 @@ export class DebugSession extends ProtocolServer {
// This default debug adapter does not support the 'completionsRequest' request.
response.body.supportsCompletionsRequest = false;

// The debug adapter leaves escaping newlines in variable values and evaluation results to the client.
response.body.supportsValueEscaping = false;

// This default debug adapter does not support the 'restart' request.
response.body.supportsRestartRequest = false;

Expand Down
10 changes: 3 additions & 7 deletions debugProtocol.json
Original file line number Diff line number Diff line change
Expand Up @@ -1346,7 +1346,7 @@
"properties": {
"value": {
"type": "string",
"description": "The new value of the variable. See capability 'supportsValueEscaping' for details about how to treat newlines in multi-line strings."
"description": "The new value of the variable."
},
"type": {
"type": "string",
Expand Down Expand Up @@ -1562,7 +1562,7 @@
"properties": {
"result": {
"type": "string",
"description": "The result of the evaluate request. See capability 'supportsValueEscaping' for details about how to treat newlines in multi-lines strings."
"description": "The result of the evaluate request."
},
"type": {
"type": "string",
Expand Down Expand Up @@ -1831,10 +1831,6 @@
},
"description": "Checksum algorithms supported by the debug adapter."
},
"supportsValueEscaping": {
"type": "boolean",
"description": "The debug adapter will be responsible for escaping newlines in variable values and evaluation results, and the client will display them as-is. If missing or false the client will escape newlines as needed."
},
"supportsRestartRequest": {
"type": "boolean",
"description": "The debug adapter supports the RestartRequest. In this case a client should not implement 'restart' by terminating and relaunching the adapter but by calling the RestartRequest."
Expand Down Expand Up @@ -2141,7 +2137,7 @@
},
"value": {
"type": "string",
"description": "The variable's value. This can be a multi-line text, e.g. for a function the body of a function. See capability 'supportsValueEscaping' for details about how to treat newlines in multi-line strings."
"description": "The variable's value. This can be a multi-line text, e.g. for a function the body of a function."
},
"type": {
"type": "string",
Expand Down
1 change: 0 additions & 1 deletion protocol/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ This npm module contains declarations for the json-based Visual Studio Code debu
## History

* 1.15.x:
* Adds a `supportsValueEscaping` capability that indicates whether the debug adapter takes care of escaping newlines in variable values and evaluation results.
* Adds a `reverseContinue` request.
* Adds a `restart` request and a corresponding `supportsRestartRequest` capability.

Expand Down
2 changes: 1 addition & 1 deletion protocol/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "vscode-debugprotocol",
"description": "Npm module with declarations for the Visual Studio Code debug protocol",
"version": "1.15.0-pre.2",
"version": "1.15.0-pre.3",
"author": "Microsoft Corporation",
"license": "MIT",
"repository": {
Expand Down
8 changes: 3 additions & 5 deletions protocol/src/debugProtocol.ts
Original file line number Diff line number Diff line change
Expand Up @@ -695,7 +695,7 @@ export module DebugProtocol {
/** Response to 'setVariable' request. */
export interface SetVariableResponse extends Response {
body: {
/** The new value of the variable. See capability 'supportsValueEscaping' for details about how to treat newlines in multi-line strings. */
/** The new value of the variable. */
value: string;
/** The type of the new value. Typically shown in the UI when hovering over the value. */
type?: string;
Expand Down Expand Up @@ -797,7 +797,7 @@ export module DebugProtocol {
/** Response to 'evaluate' request. */
export interface EvaluateResponse extends Response {
body: {
/** The result of the evaluate request. See capability 'supportsValueEscaping' for details about how to treat newlines in multi-lines strings. */
/** The result of the evaluate request. */
result: string;
/** The optional type of the evaluate result. */
type?: string;
Expand Down Expand Up @@ -927,8 +927,6 @@ export module DebugProtocol {
additionalModuleColumns?: ColumnDescriptor[];
/** Checksum algorithms supported by the debug adapter. */
supportedChecksumAlgorithms?: ChecksumAlgorithm[];
/** The debug adapter will be responsible for escaping newlines in variable values and evaluation results, and the client will display them as-is. If missing or false the client will escape newlines as needed. */
supportsValueEscaping?: boolean;
/** The debug adapter supports the RestartRequest. In this case a client should not implement 'restart' by terminating and relaunching the adapter but by calling the RestartRequest. */
supportsRestartRequest?: boolean;
}
Expand Down Expand Up @@ -1104,7 +1102,7 @@ export module DebugProtocol {
export interface Variable {
/** The variable's name. */
name: string;
/** The variable's value. This can be a multi-line text, e.g. for a function the body of a function. See capability 'supportsValueEscaping' for details about how to treat newlines in multi-line strings. */
/** The variable's value. This can be a multi-line text, e.g. for a function the body of a function. */
value: string;
/** The type of the variable's value. Typically shown in the UI when hovering over the value. */
type?: string;
Expand Down

0 comments on commit 206c57f

Please sign in to comment.