Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the 'disableValueEscaping' flag #83

Merged
merged 2 commits into from
Nov 3, 2016
Merged

Conversation

roblourens
Copy link
Member

No description provided.

@weinand
Copy link
Contributor

weinand commented Nov 3, 2016

@roblourens Thanks for the PR.

I agree that 'ValueEscaping' is more precise than 'EscapedNewlines'.
But I don't like the 'disable' because it changes the subject (and the direction) of the capability: in all other capabilities of the 'supports*' form the debug adapter is the subject. With the 'disable*' form a debug adapter would make the client the subject.

Since I do not see the a big enough benefit of this change, I suggest that we use supportsValueEscaping.

If this is OK for you please update your PR #83.

@weinand weinand merged commit 58d43ca into master Nov 3, 2016
weinand added a commit that referenced this pull request Nov 15, 2016
@weinand
Copy link
Contributor

weinand commented Nov 15, 2016

I've reverted this PR after the discussion in microsoft/vscode#14729

@weinand weinand deleted the roblou/disableValueEscaping branch December 9, 2016 10:12
@asaf400
Copy link

asaf400 commented Jun 4, 2023

but why? 🤷‍♂️

( context: bashdb multiline doesn't work at all when using 'here-doc' / 'here-string' - ''' / """. )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants