Development container definition for Elm (0.19.0) #101
Conversation
| @@ -0,0 +1,27 @@ | |||
| Copyright (c) 2014-2016, Evan Czaplicki | |||
There was a problem hiding this comment.
We can't accept contributions using alternate licenses because of the complexity of distributing them unfortunately. Is the license required here?
There was a problem hiding this comment.
The test-project folder is a straight clone of the elm-architecture-tutorial repository , which requires this license to be distributed. If we can't include it, I could remove that test-project entirely and make one from scratch that's a simple Hello World?
It wouldn't be as complete, but probably good enough to make sure the dev tools are working properly.
There was a problem hiding this comment.
@xWiiLLz Yeah I think that would be best given the license is required in the other example. Thanks!!
|
Oops! Missed you'd done some commits to address the feedback. LGTM! Merging. |
Just noticed that you had merged the PR without me making the appropriate changes (LICENSE still there). I will create a simple hello-world sample of my own and remove the licensing & other files to comply with your distribution. Will reference this in the upcoming PR. Sorry about that @Chuxel |
I wanted to try out Elm and had to install the binaries to my computer (bummer 馃), so I decided to make this container definition instead 馃槒.
As of now, there is not vscode debugger for Elm yet, which is why the Readme guides developers to run the cli command directly to start the samples.
This definition is based on debian and includes both the Elm (0.19.0) binaries as well as the Elm VS Code extension.
The test project files were taken directly from the official Elm Architecture Tutorial.