This repository has been archived by the owner on Nov 30, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development container definition for Elm (0.19.0) #101
Development container definition for Elm (0.19.0) #101
Changes from 6 commits
8dba819
891b857
54415c1
89cb8b5
be94e3c
8b90b31
1600e4f
92d2b1e
2ad201f
2165d17
b1978a3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't accept contributions using alternate licenses because of the complexity of distributing them unfortunately. Is the license required here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test-project folder is a straight clone of the elm-architecture-tutorial repository , which requires this license to be distributed. If we can't include it, I could remove that test-project entirely and make one from scratch that's a simple Hello World?
It wouldn't be as complete, but probably good enough to make sure the dev tools are working properly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xWiiLLz Yeah I think that would be best given the license is required in the other example. Thanks!!