This repository has been archived by the owner on Nov 30, 2023. It is now read-only.
Switch from tagging stubs with MAJOR.MINOR to just MAJOR #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the build tagging process for pre-built images updates dockerfiles to reference the MAJOR.MINOR version of the dev container.
This is likely too restrictive as a starting point. This PR updates the build script to instead use just the MAJOR version of the image by default.
While we could drop the version entirely, this could complicate situations where the image gets out of sync with a breaking update to devcontainer.json.